Transactional WriteRead #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @posborne (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
This was referenced Nov 25, 2019
|
Hi @posborne, did you have any chance to have a look at this? |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 3, 2019
26: Transactional WriteRead r=ryankurte a=eldruin This fixes #25 by implementing a transactional write-read without STOP in the middle. It also fixes a type cast which was the only warning present. Co-authored-by: Diego Barrios Romero <[email protected]>
Build succeeded |
bors bot
added a commit
that referenced
this pull request
Dec 3, 2019
27: Release 0.3.0 preparation r=ryankurte a=eldruin I updated the changelog with everything that happened since the 0.2.2 release and bumped the minor version because of the digital::v2. I also fixed setting the embedded-hal version to 0.2.3 because that is when the digital::v2 traits were released. This branch sits on top of #26 with the hopeful date of today :) Co-authored-by: Diego Barrios Romero <[email protected]>
bors bot
added a commit
to rust-embedded/wg
that referenced
this pull request
Jan 24, 2021
533: Add eldruin to embedded linux team r=therealprof a=eldruin I was approached by @ryankurte about joining the embedded linux team and I would be happy to. So far I have contributed to `rust-i2cdev` and `linux-embedded-hal` adding support for transactional I2C among other smaller fixes. See: - rust-embedded/rust-i2cdev#51 - rust-embedded/linux-embedded-hal#26 Other than that I guess everyone here knows me already. Nevertheless, please feel free to raise any concerns. Co-authored-by: Diego Barrios Romero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #25 by implementing a transactional write-read without STOP in the middle.
It also fixes a type cast which was the only warning present.