Document MSRV 1.32.0 and test it on CI #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @posborne (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
32 tasks
posborne
previously approved these changes
May 21, 2020
|
Thanks @eldruin, sorry for the delay in review. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 21, 2020
41: Document MSRV 1.32.0 and test it on CI r=posborne a=eldruin See: rust-embedded/wg#445 Co-authored-by: Diego Barrios Romero <[email protected]>
|
Build failed: |
|
Hmm, it does not compile on 1.32.0 due to |
|
Ping @rust-embedded/embedded-linux, perhaps we could get this merged even at 1.40.0? |
|
@eldruin There's a new version of gpio_cdev published that drops error-chain which would be another option, but I have no problem with moving to 1.40.0 for the MSRV here either. |
bors bot
added a commit
that referenced
this pull request
Jun 10, 2020
42: Update gpio-cdev and add MSRV r=posborne a=eldruin Using `gpio-cdev` 0.3 we have a MSRV of 1.36.0 due to `nix`. This superseeds #41 Co-authored-by: Diego Barrios Romero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: rust-embedded/wg#445