Fix generator usage #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealprof
reviewed
Jun 27, 2020
| @@ -298,7 +298,9 @@ | |||
| //! #[macro_use(await)] | |||
| //! extern crate nb; | |||
| //! | |||
| //! use std::ops::Generator; | |||
| //! extern crate core; | |||
There was a problem hiding this comment.
Suggested change
| //! extern crate core; |
There was a problem hiding this comment.
It does not compile otherwise.
There was a problem hiding this comment.
Superweird. Probably needs a thourough overhaul.
therealprof
reviewed
Jun 27, 2020
Comment on lines
298
to
299
| //! #[macro_use(await)] | ||
| //! extern crate nb; |
There was a problem hiding this comment.
Probably should modernize this, too, while we are at it?
There was a problem hiding this comment.
With Rust 2018 it does not build due to await being a reserved keyword.
therealprof
approved these changes
Jun 27, 2020
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #24. The generator trait definition changed in the mean time.