Add Altimeter trait and default implementaiton #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2016 12:06
This creates a trait for Altimeter sensors, providing altitude readings in meters. There is also a default implementation specified for any type that implements Barometer.
Some of the docstrings implied that the temperature_celdius, and pressure_kpa functions returned std::Options, when they really return std::Results.
|
Thanks, we'll probably be moving some of these traits out of this library into separate crates at a point, but I see no reason not to merge this until I get around to making those other changes. See #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a trait for Altimeter sensors, providing altitude readings in meters. There is also a default implementation specified for any type that implements Barometer. I also fixed some documentation that implied some functions had different return types than what they really do.