Skip to content

Run rustfmt and fix warnings #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2020
Merged

Conversation

pheki
Copy link
Contributor

@pheki pheki commented Feb 28, 2020

Most warnings were about deprecated fns, but some were about unused arguments in other platforms.

Two unused fn warnings remained, used only in #[cfg(any(target_os = "linux", target_os = "android"))] fns, and I'm not sure what to do about them:

flush_input_from_file and get_value_from_file

Thanks for your time!

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nastevens
Copy link
Member

@pheki The warnings you're seeing are because those are private functions that are only used by other functions with #[cfg(any(target_os = "linux", target_os = "android"))] applied. It should be fine to add #[cfg(any(target_os = "linux", target_os = "android"))] to the flush_input_from_file and get_value_from_file functions

@posborne posborne mentioned this pull request Mar 2, 2020
@pheki
Copy link
Contributor Author

pheki commented Mar 4, 2020

@nastevens Done!

I've also added .DS_Store to the .gitignore, which is a file sometimes created by macOS with directory metadata. I didn't think it was worth of another PR, but I'm willing to create it.

@nastevens nastevens merged commit 149dfa5 into rust-embedded:master Mar 6, 2020
@nastevens
Copy link
Member

Thanks!

@pheki pheki deleted the fix-warnings branch March 7, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants