derive debug for Pin and PinPoller, open file instead of creating in read_from_device_file #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2015 17:11
"fmt::Debug implementations should be implemented for all public types" source: http://doc.rust-lang.org/std/fmt/
|
1.0 is failing, but I'm fine with dropping support for it. I can change that separately. |
posborne
added a commit
that referenced
this pull request
Dec 4, 2015
derive debug for Pin and PinPoller, open file instead of creating in read_from_device_file
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create did not work in 1.6 nightly, didn't check on stable releases
offtopic:
My fork's master branch also uses a patched nix, that works on 1.6 nightly, but doesn't work on rust 1.5 and prior versions: https://github.com/marjakm/rust-sysfs-gpio
The breakage is related to: rust-lang/rust#29774
My nix changes have a pull request: nix-rust/nix#210