Skip to content

add static site generator #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2019
Merged

add static site generator #5

merged 3 commits into from
Jan 12, 2019

Conversation

japaric
Copy link
Member

@japaric japaric commented Dec 5, 2018

content is to be entered in data.yml

closes #2

r? @rust-embedded/resources

content is to be entered in data.yml

closes #2
css/main.css Outdated
@@ -0,0 +1,265 @@
/* Style based on the NEDERBURG Hugo theme (https://themes.gohugo.io/hugo-nederburg-theme/) */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The licence (https://github.com/appernetic/hugo-nederburg-theme/blob/master/LICENSE) requires that the copyright statement and licence text in included in all copies of substantial portions of the software. A link is not sufficient.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

included in all copies of substantial portions of the software

I have added a copy of the nederburg license. I should note that I implemented this file from scratch by inspecting the demo website (I can't really read complex CSS files). I think it still qualifies as derivative work though.

@adamgreig
Copy link
Member

LGTM, aside from @thejpster's issue.

@japaric
Copy link
Member Author

japaric commented Jan 10, 2019

@adamgreig @thejpster reminder to re-r? this PR

@japaric
Copy link
Member Author

japaric commented Jan 12, 2019

bors r=adamgreig

bors bot added a commit that referenced this pull request Jan 12, 2019
5: add static site generator r=adamgreig a=japaric

content is to be entered in data.yml

closes #2

r? @rust-embedded/resources

Co-authored-by: Jorge Aparicio <[email protected]>
@japaric
Copy link
Member Author

japaric commented Jan 12, 2019

The bors build passed (https://travis-ci.org/rust-embedded/showcase/builds/478698501) but the branch protection settings were off so I'm going to merge this manually and then fix the branch settings.

@japaric japaric merged commit dcd281e into master Jan 12, 2019
@bors bors bot deleted the template branch January 12, 2019 10:24
bors bot added a commit that referenced this pull request Feb 20, 2019
6: Add evaluation guidelines and instructions on how to submit a project r=adamgreig a=japaric

The guidelines include all I can think of at the moment. We'll probably come up
with more of them once start reviewing user submissions. And, maybe, in the
future these guidelines could become a document on "good practices for
structuring embedded applications".

Q: Is there any additional information we'll like to request from the submitter,
apart from the information in `data.yml` (see #5)? This information would be
provided in the description of the pull request. If not then we don't need a
pull request template as I suggested in #3.

r? @rust-embedded/resources

closes #3
closes #4

Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website mockup
3 participants