-
Notifications
You must be signed in to change notification settings - Fork 11
add static site generator #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
content is to be entered in data.yml closes #2
css/main.css
Outdated
@@ -0,0 +1,265 @@ | |||
/* Style based on the NEDERBURG Hugo theme (https://themes.gohugo.io/hugo-nederburg-theme/) */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The licence (https://github.com/appernetic/hugo-nederburg-theme/blob/master/LICENSE) requires that the copyright statement and licence text in included in all copies of substantial portions of the software. A link is not sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
included in all copies of substantial portions of the software
I have added a copy of the nederburg license. I should note that I implemented this file from scratch by inspecting the demo website (I can't really read complex CSS files). I think it still qualifies as derivative work though.
LGTM, aside from @thejpster's issue. |
@adamgreig @thejpster reminder to re-r? this PR |
bors r=adamgreig |
5: add static site generator r=adamgreig a=japaric content is to be entered in data.yml closes #2 r? @rust-embedded/resources Co-authored-by: Jorge Aparicio <[email protected]>
The bors build passed (https://travis-ci.org/rust-embedded/showcase/builds/478698501) but the branch protection settings were off so I'm going to merge this manually and then fix the branch settings. |
6: Add evaluation guidelines and instructions on how to submit a project r=adamgreig a=japaric The guidelines include all I can think of at the moment. We'll probably come up with more of them once start reviewing user submissions. And, maybe, in the future these guidelines could become a document on "good practices for structuring embedded applications". Q: Is there any additional information we'll like to request from the submitter, apart from the information in `data.yml` (see #5)? This information would be provided in the description of the pull request. If not then we don't need a pull request template as I suggested in #3. r? @rust-embedded/resources closes #3 closes #4 Co-authored-by: Jorge Aparicio <[email protected]>
content is to be entered in data.yml
closes #2
r? @rust-embedded/resources