Rename bit read/write methods. #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set() -> set_bit() clear() -> clear_bit() is_set() -> is_bit_set() is_clear() -> is_bit_clear() Also adds these names to the list of reserved keywords along with bit and bits so that they are suffixed with an underscore if used as a variant name.
Excellent! Thank you @adamgreig! @homunkulus r+ |
|
📌 Commit cc512a0 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set()->set_bit()clear()->clear_bit()is_set()->is_bit_set()is_clear()->is_bit_clear()Also adds these names to the list of reserved keywords along with
bitandbitsso that they are suffixed with an underscore if used as a variant name.
Also causes the
set_bit()andclear_bit()methods to be added even if the field has an enumeratedValues.#99 #92 @whitequark