Enable code generation in the absence of register reset values. #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecstatic-morse
force-pushed
the
issue-174
branch
from
e9d696d to
d6d4b82
Compare
In case no reset value is defined for a register, we suppress generation of the `write`, `reset`, and `reset_value` functions. Register values can still be safely changed using `modify`.
ecstatic-morse
force-pushed
the
issue-174
branch
from
d6d4b82 to
93ee7d0
Compare
|
Sorry, removed offending commit. |
|
@ecstatic-morse could you uncomment some of the Atmel SVD files to test this change? |
Emilgardis
approved these changes
Mar 1, 2018
|
@ecstatic-morse are you still working on this? I was misinformed with why d6d4b82 was (not) needed. Could you enable tests for ~3 Atmel SVD files? |
This was referenced Nov 19, 2018
|
I hope we can close this PR in favor of #258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second commit also generates
resetfor write-only registers. Previously it was only generated for read-write registers. I'm not sure if the previous behavior was intended. This resolves #174.