improve dev builds #324
Merged
improve dev builds #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Emilgardis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
@ryankurte can you review this PR? |
Closed
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 21, 2019
324: improve dev builds r=ryankurte a=therealprof This PR basically reverts #141 and plays with inline markers for some large dev build binary size gains Co-authored-by: Daniel Egger <[email protected]>
|
failed with on several targets. |
burrbull
reviewed
Jul 21, 2019
src/generate/peripheral.rs
Outdated
| #address as *const _ | ||
| #[inline(always)] | ||
| pub const fn ptr() -> *const #base::RegisterBlock { | ||
| #address as _ |
There was a problem hiding this comment.
incorrect cast here (signed *i32 instead of unsigned *<width>)
There was a problem hiding this comment.
That is very weird. Why could a elided type result in an incompatible pointer?
There was a problem hiding this comment.
Most likely the issue is not this change but the PhantomMarker change above. Anyway let's back that out.
Signed-off-by: Daniel Egger <[email protected]>
This shaves off a couple of bytes of any dev build Signed-off-by: Daniel Egger <[email protected]>
Turns out this @therealprof dude was wrong in blindly following general consensus that #[inline(always)] was a bad idea. Revisiting the topic showed that just #[inline] is not enough to get even very trivial functions inlined in dev mode which causes a ton of bloat and a lot of debugging fun due to many emitted extra functions without any value for the developer. Usual binary reductions by this change are in the area of 10-15% which is a lot given that even a simply blinky on Cortex-M0 is several kB already. E.g. before: 0.5% 100.0% 4.0KiB .text section size, the file size is 734.1KiB after: 0.5% 100.0% 3.7KiB .text section size, the file size is 714.5KiB Signed-off-by: Daniel Egger <[email protected]>
therealprof
force-pushed
the
branch/make-dev-builds-great-again
branch
from
5589a6c to
3d101f9
Compare
|
@ryankurte I removed the problematic change. Please have another look. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 21, 2019
324: improve dev builds r=ryankurte a=therealprof This PR basically reverts #141 and plays with inline markers for some large dev build binary size gains Co-authored-by: Daniel Egger <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically reverts #141 and plays with inline markers for some large dev build binary size gains