Use standard wording for the MSRV note #436
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
436: Use standard wording for the MSRV note r=ryankurte a=ra-kete Part of [wg/#445](rust-embedded/wg#445). svd2rust already has its MSRV documented and tested, but @adamgreig suggested updating it to use the standard wording. Since this is a special case in that the MSRV applies to the generated code, not svd2rust itself, the standard wording doesn't fully apply, so I changed it in a (hopefully) sensible way. An open question is: Should we also document the MSRV of svd2rust itself? Looking at how the CI works, currently it's implicitly guaranteed to be the same version als the MSRV for the generated code, so we could just extend the note in the README to also include svd2rust itself. Co-authored-by: Jan Teske <[email protected]>
|
Build failed: |
|
The built failed because the i686-apple-darwin Target is no longer fully supported: https://blog.rust-lang.org/2020/01/03/reducing-support-for-32-bit-apple-targets.html I suggest we simply remove it from the CI, unless there is a reason svd2rust still needs to support it? |
|
@ra-kete Yeah, let's remove it. That target is pretty silly anyway: pretty much only the very first MacBooks had only 32bit Intel MCUs, everything else had 64Bit MCUs from the start and 64Bit support was there since Lion (2011). That target was useful for legacy code bases which I highly doubt even exist since Rust 1.0 was released 4 years after Apple started actually requiring 64bit capable CPUs... |
32-bit Apple targets are no longer fully supported: https://blog.rust-lang.org/2020/01/03/reducing-support-for-32-bit-apple-targets.html
|
bors r+ |
|
Build succeeded: |
Part of wg/#445.
svd2rust already has its MSRV documented and tested, but @adamgreig suggested updating it to use the standard wording. Since this is a special case in that the MSRV applies to the generated code, not svd2rust itself, the standard wording doesn't fully apply, so I changed it in a (hopefully) sensible way.
An open question is: Should we also document the MSRV of svd2rust itself? Looking at how the CI works, currently it's implicitly guaranteed to be the same version als the MSRV for the generated code, so we could just extend the note in the README to also include svd2rust itself.