Skip to content

features for each peripheral #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2022
Merged

features for each peripheral #647

merged 3 commits into from
Jul 28, 2022

Conversation

burrbull
Copy link
Member

No description provided.

@burrbull burrbull requested a review from a team as a code owner July 28, 2022 12:50
@rust-highfive
Copy link

r? @therealprof

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 28, 2022
@therealprof
Copy link
Contributor

Looks good to me. Any other opinions, maybe @Emilgardis?

@Emilgardis
Copy link
Member

Emilgardis commented Jul 28, 2022 •
edited
Loading

should we maybe play nice and provide summary features? i.e all-peripherals and all-groups

@burrbull
Copy link
Member Author

should we maybe play nice and provide summary features? i.e all-peripherals and all-groups

Done

Emilgardis
Emilgardis approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r=therealprof,emilgardis

looks good :)

@bors
Copy link
Contributor

bors bot commented Jul 28, 2022

Build succeeded:

@bors bors bot merged commit e31074d into master Jul 28, 2022
@bors bors bot deleted the features branch July 28, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees

@therealprof therealprof

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@burrbull @rust-highfive @therealprof @Emilgardis