-
Notifications
You must be signed in to change notification settings - Fork 156
Normalize SVD names to upper case where they were to pascal case #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So... yes, I understand that right now, I am being that person who asks to change style conventions. However, I feel that there are a few factors in the favor of this change:
And I suppose if this PR is merged, then the corresponding change should be done to |
(Rust is unprecedent in embedded development :-). And C just uses integers to represent registers instead of newtypes so C code doesn't have to deal with this.) I kinda agree with the rationale outlined here but I'd like to take my time in assessing the breakage this will cause to dependent crates. |
I think you'll find the Habit bitdata types (see Habit report p.40) quite familiar, actually... |
@japaric From your latest post:
Seems like this PR would make that a bit cleaner :) |
Bascially r+ but we have to wait for inflections PR to be merged. Turns out this change won't break cortex-m-rtfm because the register_block field in the peripherals! macro can be made optional. (see japaric/cortex-m-rtfm#28) |
This is waiting on a new release of the inflections crate. |
Thank you @whitequark! @homunkulus r+ |
📌 Commit 601cc70 has been approved by |
Normalize SVD names to upper case where they were to pascal case Fixes #76. Depends on calebmer/inflections#2.
☀️ Test successful - status-appveyor, status-travis |
591: optional PascalCase for Enum values r=Emilgardis a=burrbull  without and with `--pascal_enum_values` option related: #85 r?adamgreig Co-authored-by: Andrey Zgarbul <[email protected]>
Fixes #76.
Depends on calebmer/inflections#2.