-
Notifications
You must be signed in to change notification settings - Fork 101
IRC Operational Notes #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @levex! @rust-embedded/all please review this proposal and approve it via GH review if you are in agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well
I think it makes it clearer what each level means and helps explain why we have the different levels, so I'm in favour of keeping it as-is. Perhaps we should add which levels can mute the channel (owner and operator?). What is the intended difference between "Modify the list of [x]" and "Grant [x] rights"?
This might provide an easy if formal mechanism for nominating people to be given +v/+h via PRs. But perhaps the lists should just correspond with some other data source (the organisation teams for example) so they don't need tracking separately. If we don't explicitly use it as a process to nominate people to levels then I don't think we need to track it in the repo.
Since only owners can add new ops I think we should have at least one other owner.
As Mozilla IRC is (mercifully) fairly spam-free we probably don't need to overthink muting the channel, so I see voice as more of a recognition flag than anything overly functional. Maybe we could automatically permit it to any repository contributor. |
ChanServ maintains a list of users who are (if they so choose) automatically elevated to their access level when they join. Granting someone
Good point, although I agree with your last point that Mozilla IRC is quite spam-free, for now. I suppose we can return to this when it becomes an issue.
We mentioned this on IRC, but ultimately I think that we can always ask the IRC Operators to help us out should any problem arise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but since I know next to nothing about IRC and will likely not be involved in day-to-day operations, I abstain from voting.
ops/irc.md
Outdated
|
||
IRC user mode: `+q` | ||
|
||
Rights:` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not at all important, but there's a superfluous '`' in this line.
Sure, but is there any point saying both? The ability to modify the access lists implies the ability to grant those modes.
Could we just stick "Can mute the channel (+m)" against owner and operator?
👍, happy to leave it as just the WG lead as owner then. |
Signed-off-by: Levente Kurusa <[email protected]>
b54550e
Thanks, fixed.
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent stuff.
Did this need one review, or for everyone to review? I didn't think that clicking "Approve" would actually approve it until everyone else had. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still, LGTM. ;)
@rust-embedded/all has 19 members. So far we have 5 approvals. @hannobraun @ryankurte @posborne approvals got dismissed after the last commit was pushed so you'll have to approve against. Assuming they re-approve we would still require 2 more approvals to land this. I'll bring this up again during tomorrow's meeting. Re: having more people with +q rights I would suggest giving +q rights to a future ops team. In any case, we can amend the document to address that topic later on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still know nothing about IRC, but since this seems uncontroversial, but we're currently lacking the votes to get this through, I'm changing my abstention to an approval.
I've already approved! |
@adamgreig yes, sorry! Wrong autocomplete. I meant @andre-richter (see #172 (comment)) |
I haven’t set up irc and can’t understand this PR well.... I searched for irc clients and am going to install weechat program. (Any suggestion for other recommended irc client?) |
This proposal has been approved! I'll give each one of you operator status when I see you around on IRC (e.g. next meeting). Or you can ping. @bors r+ |
bors r+ |
172: IRC Operational Notes r=japaric a=levex Hi, as discussed in issue #154, here's my proposal in a better form. [Rendered](https://github.com/levex/rust-embedded-wg/blob/irc-op-notes/ops/irc.md) There are a couple of questions I could think of: * Is there any point in listing the rights associated with each access level? * Should we have an IRC roster in the repo? * Do we need more owners? * Do we need voice (`+v`)? Best wishes, Levente Co-authored-by: Levente Kurusa <[email protected]>
Build succeeded |
@rust-embedded/all I need you all to register with NickServ so I can add you to the auto-op list. Otherwise the op status won't stick when you leave (e.g. disconnect) and rejoin the channel. The instructions for registering your nickname can be found here. Once you have registered your nickname report it back to this thread and I'll add you to the auto-op list. |
While implementing this we (@adamgreig and I) noticed that it seems to be impossible to prevent an AOP-ed user from (de)oping other users. These are the commands I used: $ /msg ChanServ AOP #rust-embedded ADD adamgreig
$ # now adamgreig gets auto-op'ed when joining the channel
$ /msg ChanServ FLAGS #rust-embedded LIST
Flags list for #rust-embedded
Number Mask Flags Creator Created
1 adamgreig BGHNOVabcfghikotuv japaric Aug 26 10:42:59 2018 UTC
$ # the 'o' flag means adamgreig can (de)op others via ChanServ
$ /msg ChanServ FLAGS #rust-embedded MODIFY adamgreig -o
$ # this removes the 'o' flag so adamgreig can no longer (de)op someone using ChanServ
$ # however they can still (de)op others using the `/mode op $name` command @levex is there a way to prevent an op'ed user from doing Also, we probably want to audit more carefull all the flags that get asigned when someone is AOP'ed. $ /msg ChanServ help FLAGS
The available flags are:
A - Automatic protect upon join
a - Allowed to (de)protect users
a - Allowed to (de)protect him/herself
b - Allowed to ban users
B - Allowed to use SAY and ACT commands
c - Allowed to use fantasy commands
f - Allowed to modify the access list
f - Allowed to view the access list
F - Allowed to issue commands restricted to channel founders
G - Allowed to use GETKEY command
g - Greet message displayed on join
H - Automatic halfop upon join
h - Allowed to (de)halfop users
h - Allowed to (de)halfop him/herself
I - Allowed to get full INFO output
i - Allowed to use the INVITE command
K - Allowed to use the AKICK command
K - Allowed to modify channel badwords list
k - Allowed to use the KICK command
K - No signed kick when SIGNKICK LEVEL is used
m - Allowed to read channel memos
N - Prevents users being kicked by Services
O - Automatic channel operator status upon join
o - Allowed to (de)op users
o - Allowed to (de)op him/herself
Q - Automatic owner upon join
q - Allowed to (de)owner users
q - Allowed to (de)owner him/herself
s - Allowed to assign/unassign a bot
s - Allowed to use the MODE command
s - Allowed to set channel settings
t - Allowed to change channel topics
u - Allowed to unban users
V - Automatic voice on join
v - Allowed to (de)voice users
v - Allowed to (de)voice him/herself |
@japaric For consistency reasons I'm going to use therealprof on IRC as well and have just registered with nickserv. |
@japaric I've registered with NickServ as |
@japaric I'm registered with NickServ as |
@japaric I'm registered with NickServ as |
@japaric I'm registered with NickServ as |
I'm already oped but for the record I'm registered as |
@japaric I am me! |
Hi,
as discussed in issue #154, here's my proposal in a better form.
Rendered
There are a couple of questions I could think of:
+v
)?Best wishes,
Levente