Skip to content

IRC Operational Notes #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2018
Merged

IRC Operational Notes #172

merged 1 commit into from
Aug 26, 2018

Conversation

levex
Copy link
Contributor

@levex levex commented Aug 14, 2018

Hi,

as discussed in issue #154, here's my proposal in a better form.

Rendered

There are a couple of questions I could think of:

  • Is there any point in listing the rights associated with each access level?
  • Should we have an IRC roster in the repo?
  • Do we need more owners?
  • Do we need voice (+v)?

Best wishes,

Levente

@levex levex requested review from dylanmckay, jcsoo, thejpster and a team as code owners August 14, 2018 18:26
@japaric
Copy link
Member

japaric commented Aug 14, 2018

Thanks @levex!

@rust-embedded/all please review this proposal and approve it via GH review if you are in agreement.

therealprof
therealprof previously approved these changes Aug 14, 2018
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

posborne
posborne previously approved these changes Aug 14, 2018
Copy link
Member

@posborne posborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

ryankurte
ryankurte previously approved these changes Aug 14, 2018
@adamgreig
Copy link
Member

Is there any point in listing the rights associated with each access level?

I think it makes it clearer what each level means and helps explain why we have the different levels, so I'm in favour of keeping it as-is. Perhaps we should add which levels can mute the channel (owner and operator?). What is the intended difference between "Modify the list of [x]" and "Grant [x] rights"?

Should we have an IRC roster in the repo?

This might provide an easy if formal mechanism for nominating people to be given +v/+h via PRs. But perhaps the lists should just correspond with some other data source (the organisation teams for example) so they don't need tracking separately. If we don't explicitly use it as a process to nominate people to levels then I don't think we need to track it in the repo.

Do we need more owners?

Since only owners can add new ops I think we should have at least one other owner.

Do we need voice (+v)?

As Mozilla IRC is (mercifully) fairly spam-free we probably don't need to overthink muting the channel, so I see voice as more of a recognition flag than anything overly functional. Maybe we could automatically permit it to any repository contributor.

@levex
Copy link
Contributor Author

levex commented Aug 15, 2018

What is the intended difference between "Modify the list of [x]" and "Grant [x] rights"?

ChanServ maintains a list of users who are (if they so choose) automatically elevated to their access level when they join. Granting someone +h (for instance) is only temporary, but if the list in ChanServ is modified then it becomes permanent in the sense that they can request ChanServ to either automatically elevate them, or on demand. Of course, higher access levels can always remove them from the ChanServ list.

Perhaps we should add which levels can mute the channel (owner and operator?).

Good point, although I agree with your last point that Mozilla IRC is quite spam-free, for now. I suppose we can return to this when it becomes an issue.

Since only owners can add new ops I think we should have at least one other owner.

We mentioned this on IRC, but ultimately I think that we can always ask the IRC Operators to help us out should any problem arise.

Copy link
Member

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but since I know next to nothing about IRC and will likely not be involved in day-to-day operations, I abstain from voting.

ops/irc.md Outdated

IRC user mode: `+q`

Rights:`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all important, but there's a superfluous '`' in this line.

@adamgreig
Copy link
Member

Granting someone +h (for instance) is only temporary, but if the list in ChanServ is modified then it becomes permanent in the sense that they can request ChanServ to either automatically elevate them, or on demand.

Sure, but is there any point saying both? The ability to modify the access lists implies the ability to grant those modes.

I suppose we can return to this when it becomes an issue.

Could we just stick "Can mute the channel (+m)" against owner and operator?

ultimately I think that we can always ask the IRC Operators to help us out should any problem arise.

👍, happy to leave it as just the WG lead as owner then.

Signed-off-by: Levente Kurusa <[email protected]>
@levex levex dismissed stale reviews from ryankurte, posborne, and therealprof via b54550e August 16, 2018 12:48
@levex
Copy link
Contributor Author

levex commented Aug 16, 2018

@hannobraun:

Not at all important, but there's a superfluous '`' in this line.

Thanks, fixed.

Could we just stick "Can mute the channel (+m)" against owner and operator?

Done!

Copy link
Contributor

@thejpster thejpster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent stuff.

@thejpster
Copy link
Contributor

Did this need one review, or for everyone to review? I didn't think that clicking "Approve" would actually approve it until everyone else had.

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, LGTM. ;)

@japaric japaric added the RFC label Aug 17, 2018
@japaric
Copy link
Member

japaric commented Aug 20, 2018

@rust-embedded/all has 19 members. So far we have 5 approvals.

@hannobraun @ryankurte @posborne approvals got dismissed after the last commit was pushed so you'll have to approve against.

Assuming they re-approve we would still require 2 more approvals to land this. I'll bring this up again during tomorrow's meeting.

Re: having more people with +q rights I would suggest giving +q rights to a future ops team. In any case, we can amend the document to address that topic later on.

Copy link
Member

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still know nothing about IRC, but since this seems uncontroversial, but we're currently lacking the votes to get this through, I'm changing my abstention to an approval.

@jamesmunns jamesmunns self-requested a review August 21, 2018 18:06
@japaric
Copy link
Member

japaric commented Aug 22, 2018

Current vote count: 8.

Votes required to approve this: 10.

ping @adamgreig @posborne @dvc94ch @sekineh @nerdyvaishali @awygle @pftbest @cr1901 reminder to vote on this. We had some spammers in #rust-embedded and other rust channels today :-(.

@adamgreig
Copy link
Member

I've already approved!

@japaric
Copy link
Member

japaric commented Aug 22, 2018

@adamgreig yes, sorry! Wrong autocomplete. I meant @andre-richter (see #172 (comment))

@sekineh
Copy link

sekineh commented Aug 22, 2018

I haven’t set up irc and can’t understand this PR well....

I searched for irc clients and am going to install weechat program. (Any suggestion for other recommended irc client?)

@japaric
Copy link
Member

japaric commented Aug 26, 2018

This proposal has been approved!

I'll give each one of you operator status when I see you around on IRC (e.g. next meeting). Or you can ping.

@bors r+

@japaric
Copy link
Member

japaric commented Aug 26, 2018

bors r+

bors bot added a commit that referenced this pull request Aug 26, 2018
172: IRC Operational Notes r=japaric a=levex

Hi,

as discussed in issue #154, here's my proposal in a better form.

[Rendered](https://github.com/levex/rust-embedded-wg/blob/irc-op-notes/ops/irc.md)

There are a couple of questions I could think of:
* Is there any point in listing the rights associated with each access level?
* Should we have an IRC roster in the repo?
* Do we need more owners?
* Do we need voice (`+v`)?

Best wishes,

Levente

Co-authored-by: Levente Kurusa <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 26, 2018

Build succeeded

@bors bors bot merged commit b54550e into rust-embedded:master Aug 26, 2018
@japaric
Copy link
Member

japaric commented Aug 26, 2018

@rust-embedded/all I need you all to register with NickServ so I can add you to the auto-op list. Otherwise the op status won't stick when you leave (e.g. disconnect) and rejoin the channel.

The instructions for registering your nickname can be found here. Once you have registered your nickname report it back to this thread and I'll add you to the auto-op list.

@japaric
Copy link
Member

japaric commented Aug 26, 2018

While implementing this we (@adamgreig and I) noticed that it seems to be impossible to prevent an AOP-ed user from (de)oping other users. These are the commands I used:

$ /msg ChanServ AOP #rust-embedded ADD adamgreig

$ # now adamgreig gets auto-op'ed when joining the channel

$ /msg ChanServ FLAGS #rust-embedded LIST
Flags list for #rust-embedded
Number  Mask       Flags               Creator  Created
1       adamgreig  BGHNOVabcfghikotuv  japaric  Aug 26 10:42:59 2018 UTC

$ # the 'o' flag means adamgreig can (de)op others via ChanServ

$ /msg ChanServ FLAGS #rust-embedded MODIFY adamgreig -o

$ # this removes the 'o' flag so adamgreig can no longer (de)op someone using ChanServ

$ # however they can still (de)op others using the `/mode op $name` command

@levex is there a way to prevent an op'ed user from doing /mode +o in the channel? If there isn't then we should update the document to reflect the current semantics.

Also, we probably want to audit more carefull all the flags that get asigned when someone is AOP'ed.

$ /msg ChanServ help FLAGS
The available flags are:
  A - Automatic protect upon join
  a - Allowed to (de)protect users
  a - Allowed to (de)protect him/herself
  b - Allowed to ban users
  B - Allowed to use SAY and ACT commands
  c - Allowed to use fantasy commands
  f - Allowed to modify the access list
  f - Allowed to view the access list
  F - Allowed to issue commands restricted to channel founders
  G - Allowed to use GETKEY command
  g - Greet message displayed on join
  H - Automatic halfop upon join
  h - Allowed to (de)halfop users
  h - Allowed to (de)halfop him/herself
  I - Allowed to get full INFO output
  i - Allowed to use the INVITE command
  K - Allowed to use the AKICK command
  K - Allowed to modify channel badwords list
  k - Allowed to use the KICK command
  K - No signed kick when SIGNKICK LEVEL is used
  m - Allowed to read channel memos
  N - Prevents users being kicked by Services
  O - Automatic channel operator status upon join
  o - Allowed to (de)op users
  o - Allowed to (de)op him/herself
  Q - Automatic owner upon join
  q - Allowed to (de)owner users
  q - Allowed to (de)owner him/herself
  s - Allowed to assign/unassign a bot
  s - Allowed to use the MODE command
  s - Allowed to set channel settings
  t - Allowed to change channel topics
  u - Allowed to unban users
  V - Automatic voice on join
  v - Allowed to (de)voice users
  v - Allowed to (de)voice him/herself

@therealprof
Copy link
Contributor

@japaric For consistency reasons I'm going to use therealprof on IRC as well and have just registered with nickserv.

@japaric japaric mentioned this pull request Aug 28, 2018
@hannobraun
Copy link
Member

@japaric I've registered with NickServ as hannobraun.

@nastevens
Copy link
Member

@japaric I'm registered with NickServ as nastevens

@ryankurte
Copy link
Contributor

@japaric I'm registered with NickServ as ryankurte

@andre-richter
Copy link
Member

@japaric I'm registered with NickServ as andre-richter

@ithinuel
Copy link
Member

ithinuel commented Sep 5, 2018

I'm already oped but for the record I'm registered as ithinuel.

@jamesmunns
Copy link
Member

@japaric I am me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.