Skip to content

[RFC] blog.rust-embedded.org #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2018
Merged

[RFC] blog.rust-embedded.org #191

merged 1 commit into from
Aug 26, 2018

Conversation

japaric
Copy link
Member

@japaric japaric commented Aug 22, 2018

This a proposal to create and maintain our own blog.

Rendered version of this proposal

This proposal (PR) needs at least 10 votes (approvals) from @rust-embedded/all
to be accepted. After the proposal has been accepted we'll proceed to implement
it.

@rust-embedded/all please vote on this proposal using pull request reviews.
Or if you have a concern leave a comment.

cc #148

@japaric japaric requested review from dylanmckay, jcsoo and a team as code owners August 22, 2018 12:23
@japaric japaric added the needs-decision This RFC or PR needs to be approved by the majority of reviewers before it's merged label Aug 22, 2018
hannobraun
hannobraun approved these changes Aug 22, 2018
View reviewed changes
Copy link
Member

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you, @japaric!

korken89
korken89 approved these changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

sekineh
sekineh reviewed Aug 22, 2018
View reviewed changes
Copy link

@sekineh sekineh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I’m @sekineh from irr2018 team.

I think it’s generally OK, but every blog post must be announced somewhere.

I suppose we use the channels like:

  • Twitter
  • User forum
  • RSS
  • This week in Rust (Important!)

@jamesmunns jamesmunns self-requested a review August 22, 2018 20:40
jamesmunns
jamesmunns approved these changes Aug 22, 2018
View reviewed changes
Copy link
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ithinuel
ithinuel reviewed Aug 24, 2018
View reviewed changes
rfcs/0000-blog.md
# Drawbacks
[drawbacks]: #drawbacks

- Readers would lose the ability to comment on newsletters and announcements.
Copy link
Member

@ithinuel ithinuel Aug 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have a disqus as the comment section in the articles ?
I rather use a forum post/reddit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are trying to avoid having to host anything ourselves for now; I don't know if that'd be the case for disqus. My preference would be to use the users forum as mentioned in the next line of the RFC.

@jamesmunns
Copy link
Member

This seems to now have 10 approvals. I will wait to merge, to see if anyone has any last minute objections.

I have created https://github.com/rust-embedded/blog, currently with no content. My first plan would be to move all of the newsletters to this new blog, and use this space to publish the next newsletter tomorrow.

@jamesmunns jamesmunns mentioned this pull request Aug 26, 2018
Merged
@jamesmunns
Copy link
Member

There don't seem to be any outstanding comments (sorry for only waiting an hour), so I will go ahead and merge.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 26, 2018

👎 Rejected by label

@jamesmunns jamesmunns removed the needs-decision This RFC or PR needs to be approved by the majority of reviewers before it's merged label Aug 26, 2018
@jamesmunns
Copy link
Member

Trying again after removing label

bors r+

bors bot added a commit that referenced this pull request Aug 26, 2018
@bors @japaric
Merge #191
899bae8 
191: [RFC] blog.rust-embedded.org r=jamesmunns a=japaric

This a proposal to create and maintain our own blog.

[Rendered version of this proposal](https://github.com/rust-embedded/wg/blob/blog/rfcs/0000-blog.md)

This proposal (PR) needs at least 10 votes (approvals) from @rust-embedded/all
to be accepted. After the proposal has been accepted we'll proceed to implement
it.

@rust-embedded/all please vote on this proposal using [pull request reviews].
Or if you have a concern leave a comment.

[pull request reviews]: https://help.github.com/articles/about-pull-request-reviews/

cc #148

Co-authored-by: Jorge Aparicio <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 26, 2018

Build succeeded

@bors bors bot merged commit 08ca2f2 into master Aug 26, 2018
@bors bors bot deleted the blog branch August 26, 2018 05:40
@adamgreig
Copy link
Member

This was merged, but the RFC document is still 0000-blog.md. What's the process for numbering it?

@japaric
Copy link
Member Author

japaric commented Aug 28, 2018

It should have the same number as the PR number that merged it. That would be: 0191-*.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ithinuel ithinuel ithinuel left review comments

@posborne posborne posborne approved these changes

@adamgreig adamgreig adamgreig approved these changes

@hannobraun hannobraun hannobraun approved these changes

@danc86 danc86 danc86 approved these changes

@ryankurte ryankurte ryankurte approved these changes

@korken89 korken89 korken89 approved these changes

@thejpster thejpster thejpster approved these changes

@jamesmunns jamesmunns jamesmunns approved these changes

@sekineh sekineh sekineh approved these changes

@andre-richter andre-richter andre-richter approved these changes

@dylanmckay dylanmckay Awaiting requested review from dylanmckay

@jcsoo jcsoo Awaiting requested review from jcsoo

Assignees
No one assigned
Labels
T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.