Skip to content

Fix ithinuel's link #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2018
Merged

Fix ithinuel's link #197

merged 1 commit into from
Aug 26, 2018

Conversation

jamesmunns
Copy link
Member

Fixed the link for @ithinuel

Fixed the link for @ithinuel
@jamesmunns jamesmunns requested a review from a team August 26, 2018 05:37
@jamesmunns
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Aug 26, 2018
197: Fix ithinuel's link r=jamesmunns a=jamesmunns

Fixed the link for @ithinuel

Co-authored-by: James Munns <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 26, 2018

Build succeeded

@bors bors bot merged commit 4bfa7c5 into master Aug 26, 2018
@bors bors bot deleted the fix-link branch August 26, 2018 07:51
@japaric
Copy link
Member

japaric commented Aug 26, 2018

We have had markdown errors before. Would it make sense to check the markdown syntax in the CI? Does such a markdown checker even exist?

@korken89
Copy link
Contributor

@korken89
Copy link
Contributor

korken89 commented Aug 26, 2018

I gave mdcheckr a try and it works quite nicely (on my trustflight project):

$ mdcheckr README.md                                                                                                         [12:52:11]
Checking README.md ..
- Link https://travis-ci.org/korken89/trustflight_firmware [ OK ]
- Link https://github.com/korken89/kfly_firmware [ OK ]
- Link https://github.com/japaric/cortex-m-rtfm [ OK ]
- Link https://github.com/korken89/crect [ OK ]
- Link https://tools.ietf.org/html/draft-ietf-pppext-cobs-00 [ OK ]
- Link https://github.com/korken89/trustflight_hardware [ OK ]
- Link https://github.com/korken89 [ OK ]
- Link LICENSE-APACHE [ OK ]
- Link http://www.apache.org/licenses/LICENSE-2.0 [ OK ]
- Link LICENSE-MIT [ OK ]
- Link http://opensource.org/licenses/MIT [ OK ]
- Image https://travis-ci.org/korken89/trustflight_firmware.svg?branch=master [ OK ]

cortex-m-rt had some errors, that are false positives:

$ mdcheckr README.md                                                                                                                  [12:54:15]
Checking README.md ..
- Link https://crates.io/crates/cortex-m-rt [ FAIL ]
Warning:README.md:1:Broken link 'https://crates.io/crates/cortex-m-rt'
- Link https://crates.io/crates/cortex-m-rt [ FAIL ]
Warning:README.md:1:Broken link 'https://crates.io/crates/cortex-m-rt'
- Link https://github.com/rust-embedded/wg#the-cortex-m-team [ OK ]
- Link https://docs.rs/cortex-m-rt [ OK ]
- Link LICENSE-APACHE [ OK ]
- Link http://www.apache.org/licenses/LICENSE-2.0 [ OK ]
- Link LICENSE-MIT [ OK ]
- Link http://opensource.org/licenses/MIT [ OK ]
- Link CODE_OF_CONDUCT.md [ OK ]
- Link https://github.com/rust-embedded/wg#the-cortex-m-team [ OK ]
- Image https://img.shields.io/crates/v/cortex-m-rt.svg [ OK ]
- Image https://img.shields.io/crates/d/cortex-m-rt.svg [ OK ]
Done, with 2 problems(s) found.

@korken89
Copy link
Contributor

korken89 commented Aug 26, 2018

Any link to crates.io give a false negative, but I opened an issue for it: mike42/mdcheckr#17

@korken89
Copy link
Contributor

I fixed and PRed it (mike42/mdcheckr#18), if it is merged it is working on all crates I tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants