Skip to content

patches (N50: sm64jsarchive #1474) #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2024
Merged

patches (N50: sm64jsarchive #1474) #1527

merged 4 commits into from
Jun 13, 2024

Conversation

GManTheMarioGuy
Copy link
Contributor

forgot to patch these up! sorry :P

(n50 sm64jsarchive #1474 is what im making the patch for)

@GManTheMarioGuy
patches (N50: sm64jsarchive #1474)
3e0be64 
forgot to fix these up! sorry :P
@GManTheMarioGuy
fix
02be20d
@GManTheMarioGuy
Copy link
Contributor Author

@janhohenheim Merge this whenever you can, please 😄

Vrixyz
Vrixyz reviewed Jun 13, 2024
View reviewed changes
Vrixyz
Vrixyz approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@Vrixyz Vrixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpick but looks good to me.

@janhohenheim
Copy link
Collaborator

Thanks for the patches :)

@janhohenheim janhohenheim merged commit f01542b into rust-gamedev:source Jun 13, 2024
@GManTheMarioGuy
Copy link
Contributor Author

small nitpick but looks good to me.

thanks for catching that! i didnt notice it

@GManTheMarioGuy
Copy link
Contributor Author

Thanks for the patches :)

thanks for merging this! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vrixyz Vrixyz Vrixyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GManTheMarioGuy @janhohenheim @Vrixyz