Skip to content

N31: Name Needed #949 #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 7, 2022
Merged

N31: Name Needed #949 #950

merged 7 commits into from
Mar 7, 2022

Conversation

DomWilliams0
Copy link
Contributor

@DomWilliams0 DomWilliams0 commented Mar 2, 2022 •
edited
Loading

Adds progress on Name Needed. Thank you!

#949

@DomWilliams0 DomWilliams0 mentioned this pull request Mar 2, 2022
Closed
48 tasks
17cupsofcoffee
17cupsofcoffee approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good.

The GIF is a little on the big side (though still just within our usual limit), but EZGif doesn't seem to be able to improve it. If you can optimize it on your end, it'd be appreciated, but not essential!

@DomWilliams0
Copy link
Contributor Author

I shrunk it down to 2.1MB by resizing it a bit, hope that's more manageable

@AngelOnFira AngelOnFira merged commit 20de6c3 into rust-gamedev:source Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

@AngelOnFira AngelOnFira AngelOnFira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DomWilliams0 @17cupsofcoffee @AngelOnFira