Skip to content

Disallow compile warnings in CI #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- run: cargo check ${{ matrix.features }}
- run: RUSTFLAGS="--deny warnings" cargo check ${{ matrix.features }}

msrv:
runs-on: ubuntu-latest
2 changes: 2 additions & 0 deletions benches/fold_specialization.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(unstable_name_collisions)]

use criterion::{criterion_group, criterion_main, Criterion};
use itertools::Itertools;

2 changes: 2 additions & 0 deletions benches/tree_fold1.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(deprecated)]

use criterion::{criterion_group, criterion_main, Criterion};
use itertools::{cloned, Itertools};

1 change: 1 addition & 0 deletions src/size_hint.rs
Original file line number Diff line number Diff line change
@@ -29,6 +29,7 @@ pub fn add_scalar(sh: SizeHint, x: usize) -> SizeHint {
}

/// Subtract `x` correctly from a `SizeHint`.
#[cfg(feature = "use_alloc")]
#[inline]
pub fn sub_scalar(sh: SizeHint, x: usize) -> SizeHint {
let (mut low, mut hi) = sh;
2 changes: 1 addition & 1 deletion src/tuple_impl.rs
Original file line number Diff line number Diff line change
@@ -111,7 +111,7 @@ where
// not yet produced as a tuple.
let buffered = T::buffer_len(&self.buf);
// To that, we must add the size estimates of the underlying iterator.
let (mut unbuffered_lo, mut unbuffered_hi) = self.iter.size_hint();
let (unbuffered_lo, unbuffered_hi) = self.iter.size_hint();
// The total low estimate is the sum of the already-buffered elements,
// plus the low estimate of remaining unbuffered elements, divided by
// the tuple size.
2 changes: 2 additions & 0 deletions tests/quick.rs
Original file line number Diff line number Diff line change
@@ -3,6 +3,8 @@
//!
//! In particular we test the tedious size_hint and exact size correctness.

#![allow(deprecated, unstable_name_collisions)]

use itertools::free::{
cloned, enumerate, multipeek, peek_nth, put_back, put_back_n, rciter, zip, zip_eq,
};
2 changes: 2 additions & 0 deletions tests/specializations.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(unstable_name_collisions)]

use itertools::Itertools;
use quickcheck::quickcheck;
use std::fmt::Debug;
1 change: 1 addition & 0 deletions tests/test_core.rs
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
//! option. This file may not be copied, modified, or distributed
//! except according to those terms.
#![no_std]
#![allow(deprecated)]

use crate::it::chain;
use crate::it::free::put_back;
2 changes: 2 additions & 0 deletions tests/test_std.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(unstable_name_collisions)]

use crate::it::cloned;
use crate::it::free::put_back_n;
use crate::it::free::rciter;