Skip to content

Remove unnecessary visibilities #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Remove unnecessary visibilities #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ pub mod segtree;
pub mod string;
pub mod twosat;

pub(crate) mod internal_bit;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q. Why Is this pub(crate) in lib.rs is unnecessary? Because It is in lib.rs(root of crate)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. In the crate root, pub(crate) is equivalent to pub(self), and

pub(self) item is the same as if one had written just item.

How is pub(self) visibility different from no pub attribute? - Stack Overflow

But it may be a matter of preference.

pub(crate) mod internal_math;
pub(crate) mod internal_queue;
pub(crate) mod internal_scc;
pub(crate) mod internal_type_traits;
mod internal_bit;
mod internal_math;
mod internal_queue;
mod internal_scc;
mod internal_type_traits;

pub use convolution::{convolution, convolution_i64};
pub use dsu::Dsu;
Expand Down