-
Notifications
You must be signed in to change notification settings - Fork 29
Add internal modules into lib.rs and fix visibility #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I prefer exposing functions/structs directly in like Line 14 in 5809126
to ac_library_rs::fenwick_tree::FenwickTree .That's because ACL adopts the same policy. ( using namespace atcoder; imports everything.)
I'd like to hear what other contributors think. |
As a compromise, we have an another option to add That adapts to the policy of original ACL, I think. (as it is intended to be used with pub use crate::fenwicktree::FenwickTree; |
We also have to take into consideration that this crate will be unlikely introduced to the system of AtCoder. https://twitter.com/chokudai/status/1303025509488496645 The users have to expand the code with some tool. (e.g. hatoo/cargo-snippet, shino16/cargo-auto-bundle, qryxip/cargo-equip) |
Thanks. That makes sense to me. Let me make |
let us merge. |
Add
internal_***
modules intolib.rs
and fix the visibility of modules like the following:Change public modules frommod
topub mod
so that the users can import them.pub(crate) mod
to allow other modules can use them internally.