forked from rust-lang/rust-by-example
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix a typo and make a minor improvement #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
noritada
wants to merge
206
commits into
rust-lang-ja:ja
Choose a base branch
from
noritada:fix/typos
base: ja
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 443fc03.
Fix an external link to absolute
Fix some broken links in ja.po
Update mdbook version in CI
Adjust translation build on CI
Add explicit section link
Update ja.po based on the latest master
Split out a section showing how we get "free" implementation of the `Into` trait if the `From` trait is already defined.
Clarify interchangability for From and Into
Fixes grammatical inconsistencies, and makes the paragraph much easier to read as it flows better
s/We can do similar/We can do something similar
Adding a note to the effect that whilst implementing `From` for a type will provide it w/ `Into`, it doesn't work the other way around: implementing `Into` will not give you `From`.
…o.md-into_precision Add precision on From/Into asymmetry to from_into.md
Fix CI failure
Update mdbook-i18n-helpers to 0.3.3
…tation from editable to ignore to better reflect its purpose and avoid confusion. The next_birthday function is not meant to be compiled as there is missing main function. Changed the code block annotation from editable to ignore to better reflect its purpose and avoid confusion.
The example is not meant to be compiled. Changed the code block ann…
- Replaced `norun` with `no_run` to align with current documentation standards
Fix typo in Japanese translation
fix(docs): standardize on `no_run` attribute for documentation examples
The example is not meant to be compiled. Changed the code block annotation from editable to ignore to better reflect its purpose and avoid confusion as there require the arguments to run the code properly with out any errors
#[should_panic = "msg"] is shorthand for #[should_panic(expected = "msg")]
added a shorthand for the #[should_panic(expected = "msg")
The example is not meant to be compiled with out passing arguments.
Add example to comment.md to teach how to toggle a whole code block using block comments
Update book.toml rename `author` field to `authors`
…e name This updates the Documentation Testing (21.2) chapter to assume a crate name of `playground` instead of `doccomments`. This allows for the code contained within to be copy-pasted directly into play.rust-lang.org to run; anyone who would want to reproduce this locally would want to create a `playground` library. Fixes rust-lang#1656.
fix(rust-lang#1656): update doc tests to use `playground` as the crate name
Fix syntax highligting
introduce new @media query to set a higher content width on ultra wide screens
…ltra wide screens"
…x/1936 Revert "introduce new @media query to set a higher content width on ultra wide screens"
This adds an edit button on every page, which opens GitHub editor when clicked
allow easy fixes
- Updated the `POT-Creation-Date` to reflect the new date. - Adjusted line breaks in several translation strings for better readability. - Cleaned up comment references in the translation files for consistency. - Ensured proper formatting in translated strings to maintain clarity and accuracy.
Update Chinese translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRANSLATING_JA.mdを拝見してこちらにPRを出しております。
レビューをお願いいたします。
origin/masterへのjaの追従度合いのためにPRの差分が大きく見えてしまっていますが、実体は
561cdb8 のみになります。