-
Notifications
You must be signed in to change notification settings - Fork 1.7k
breaking styles after change default theme #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The problem is that rust-by-example's
|
I've been having this problem as well. What really bugged me was that locally it works fine, but when I push it to Github pages the icons all disappear. I just noticed it's not only me: https://rust-lang-nursery.github.io/edition-guide/ |
@cauebs interesting. I believe the Rust by Example issue is related to the custom theme's index.hbs not being updated for the new mdbook version, but the edition guide doesn't use any custom themeing. Does your book? Perhaps there's some other issue at play. Downloading a complete copy of the edition from the github pages site, the _FontAwesome directory is completely missing. I assume that, since it works locally, this is a problem related to pages? |
Ah, okay: https://help.github.com/articles/files-that-start-with-an-underscore-are-missing/
To me this doesn't indicate that the not-built files won't end up on the target site, but that is actually the case: https://stackoverflow.com/questions/6397780 I verified this by making a github pages site and renaming the You can work around this at the moment by adding a |
After change
f01bf88
f01bf88#diff-9f0d373829e789d9a6923dd290c5b174L21
Missing button icons published on github.com version of the book

Book is here:
https://rurust.github.io/rust-by-example-ru/index.html
The text was updated successfully, but these errors were encountered: