Skip to content

Fix FontAwesome directory missing from Github Pages sites #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2018

Conversation

mattico
Copy link
Contributor

@mattico mattico commented May 15, 2018

Fixes #693

https://help.github.com/articles/files-that-start-with-an-underscore-are-missing/

By default, Jekyll does not build any files or directories that

  • are hidden or used for backup (indicated by names that start with . or #, or that end with ~);
  • contain site content (indicated by names that start with _); or
  • are excluded in the site configuration.

To me this doesn't indicate that the not-built files won't end up on the target site, but that is actually the case: https://stackoverflow.com/questions/6397780

I verified that this build does create a working Github Pages site.

mattico added 2 commits May 15, 2018 12:34
to allow users to have other files with leading underscore names.
@azerupi azerupi merged commit f154b2f into rust-lang:master May 15, 2018
@azerupi
Copy link
Contributor

azerupi commented May 15, 2018

I noticed this behavior recently too.
Thanks for the fix!

@mark-i-m
Copy link
Member

mark-i-m commented Jul 8, 2018

Is there any chance we can get a new crates.io release? This is affecting quite a number of books.

@mattico
Copy link
Contributor Author

mattico commented Jul 9, 2018

@Michael-F-Bryan usually does that, but he's been busy recently.

@Michael-F-Bryan
Copy link
Contributor

Unfortunately I've been a bit busy with work recently and not had time for my personal projects, but I'll make another release around lunch time.

As a side note, I'd hate for mdbook to be neglected on my account. @mattico , you may want to ask @steveklabnik about getting commit rights for the repository so you can merge PRs (if you can't already).

@Michael-F-Bryan
Copy link
Contributor

Version 0.1.8 is on crates.io 🎉

Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
Fix FontAwesome directory missing from Github Pages sites
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants