Skip to content

MSRV regression on Windows #597

@camshaft

Description

@camshaft

We run rustc 1.71.1 in our CI and noticed that the Windows builds started failing yesterday: https://github.com/aws/s2n-quic/actions/runs/8394213178/job/22990857677?pr=2159#step:8:390.

The newest release seems to be using ptr::from_ref, which was not stabilized until 1.76.0. However, the documented MSRV in the backtrace crate is 1.65.0:

rust-version = "1.65.0"

Either we should use something that is compatible with 1.65 or the MSRV needs to be bumped.

I also noticed that the CI does not test against your advertised MSRV:

- os: ubuntu-20.04
rust: stable
- os: ubuntu-20.04
rust: beta
- os: ubuntu-20.04
rust: nightly
- os: macos-latest
rust: stable
- os: macos-latest
rust: nightly
# Note that these are on nightly due to rust-lang/rust#63700 not being
# on stable yet
- os: windows-latest
rust: stable-x86_64-msvc
- os: windows-latest
rust: stable-i686-msvc
- os: windows-latest
rust: stable-x86_64-gnu
This should also be addressed :).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions