-
Notifications
You must be signed in to change notification settings - Fork 33
feat: track mergeability #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Kobzol is the goal now just to track merge ability, more specifically |
Yes, I think that is a good start :) |
2563e3f
to
75a3781
Compare
ca57e00
to
08b50c6
Compare
Due to this PR becoming an absolute beast, part of it has been split - see #230. Once that has been merged, this one will continue on from there. |
8264122
to
a6f30b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Left a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Please squash and we can merge it.
c196eb4
to
8099e0c
Compare
8099e0c
to
f872320
Compare
Squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I modified the PR description, as this doesn't fully fix #218 yet.
Related issue: #218
This PR tracks merge ability. It adds a new column:
merge_state
.Homu Implementation
mergeable
column in thepull
tablemergeable
is set toNone
mergeable
is set toNone
only if base branch has changedmerge_state
set toNone
mergeable
ofNone
are scheduled to refetch in a background task via a queueProposed Implementation
merge_state
column in thepull_request
tablemerge_state
is set tounknown
merge_state
is set based on payload valueunknown
, whereas with the other events it is alwaysunknown
(due to the nature of the events)merge_state
set tounknown