Error message colouring broken (on Windows) with 1.74

[StevePitts]

After upgrading to Rust 1.74.0 some of the message colouring and highlighting disappears when cargo or rustc are used in a Windows 10 console session (Take Command, cmd.exe and Powershell all exhibit the same behaviour):

As the above image demonstrates this was working fine with 1.73.0

[StevePitts]

It is so old that I don't see that it can be relevant, but this existing issue: rust-lang/rust#49322 was similar

[Noratrieb]

Thanks for the report! It would be super useful if you could bisect this regression using the cargo-bisect-rustc tool!

[StevePitts]

It would be super useful if you could bisect this regression

That was relatively painless, once I'd figured out the Windows specific nuances and turned off AVG!?

searched nightlies: from nightly-2023-08-20 to nightly-2023-10-01
regressed nightly: nightly-2023-10-01
searched commit range: rust-lang/rust@8ce4540...ca62d2c
552
regressed commit: rust-lang/rust@1770912

bisected with cargo-bisect-rustc v0.6.7

Host triple: x86_64-pc-windows-msvc
Reproduce with:

cargo bisect-rustc --start=1.73.0 --end=1.74.0

It might be worth noting that the output from the bisect tool was littered with ANSI control sequences so it looks like anstream doesn't work as intended on my Windows 10.

[Noratrieb]

thank you very much! this looks like a cargo issue then, @weihanglo could you move the issue?

[weihanglo]

Transferred.

Haven't yet investigated but is very like due to this PR #12751.

[epage]

So if I understood this correctly, cargo is correctly colored when it is directly printing something but not when its taking the colored output from rustc and printing that.

... that is odd because it should all be going through the same code path. I'll likely not be able to dig into this until monday

[StevePitts]

I can confirm that if I use rustc directly then the output is correctly coloured

[epage]

I tested cargo 1.74.0 within cmd on Windows 10.0.19045 and cannot reproduce this.

From wikipedia, it sounds like Windows 10 version 1511 is the first version with ANSI escape codes. Huh, for some reason I thought this was back in the Windows 8 days

Can you confirm what version of Windows you are using? To better understand the scope of the problem, how come you are on such an old build of Windows 10?

If this is a pre-1511 build of Windows, then that means wincon is being used. By the output, cargo is doing things correctly but we aren't telling rustc to do things correctly.

[epage]

@StevePitts could you run the following and report the results?

$ git clone https://github.com/rust-cli/anstyle.git
$ cd anstyle
$ cargo run -p anstyle-query --example query
$ cargo run -p anstyle-wincon --example dump-wincon
$ cargo run -p anstream --example query-stream
$ cargo run -p anstream --example dump-stream