-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Closed
Labels
A-cli-helpArea: built-in command-line helpArea: built-in command-line helpC-cleanupCategory: cleanup within the codebaseCategory: cleanup within the codebaseE-easyExperience: EasyExperience: EasyP-lowPriority: LowPriority: LowS-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewStatus: Issue or feature is accepted, and has a team member available to help mentor or review
Description
Problem
Renovate bot found a newer version available for dependency handlebars
in #13231. handlebars
is used by mdman
for templatizing and generating man pages.
However, the new version has some API changes that need to be fixed:
Build failure. Click to See details
error[E0107]: struct takes 1 lifetime argument but 2 lifetime arguments were supplied
--> crates/mdman/src/hbs.rs:177:9
|
177 | d: &Decorator<'_, '_>,
| ^^^^^^^^^ -- help: remove this lifetime argument
| |
| expected 1 lifetime argument
|
note: struct defined here, with 1 lifetime parameter: `'rc`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/handlebars-5.0.0/src/render.rs:452:12
|
452 | pub struct Decorator<'rc> {
| ^^^^^^^^^ ---
error[E0107]: struct takes 1 lifetime argument but 2 lifetime arguments were supplied
--> crates/mdman/src/hbs.rs:45:13
|
45 | h: &Helper<'reg, 'rc>,
| ^^^^^^ --- help: remove this lifetime argument
| |
| expected 1 lifetime argument
|
note: struct defined here, with 1 lifetime parameter: `'rc`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/handlebars-5.0.0/src/render.rs:306:12
|
306 | pub struct Helper<'rc> {
| ^^^^^^ ---
error[E0107]: struct takes 1 lifetime argument but 2 lifetime arguments were supplied
--> crates/mdman/src/hbs.rs:86:13
|
86 | h: &Helper<'reg, 'rc>,
| ^^^^^^ --- help: remove this lifetime argument
| |
| expected 1 lifetime argument
|
note: struct defined here, with 1 lifetime parameter: `'rc`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/handlebars-5.0.0/src/render.rs:306:12
|
306 | pub struct Helper<'rc> {
| ^^^^^^ ---
error[E0107]: struct takes 1 lifetime argument but 2 lifetime arguments were supplied
--> crates/mdman/src/hbs.rs:144:13
|
144 | h: &Helper<'reg, 'rc>,
| ^^^^^^ --- help: remove this lifetime argument
| |
| expected 1 lifetime argument
|
note: struct defined here, with 1 lifetime parameter: `'rc`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/handlebars-5.0.0/src/render.rs:306:12
|
306 | pub struct Helper<'rc> {
| ^^^^^^ ---
Steps
- Clone
rust-lang/cargo
- Run
cargo build-man
- Fix the build failure.
Possible Solution(s)
Look into what have been changed in handlebars and update accordingly.
Version
add15366eaf3f3eb84717d3b8b71902ca36a7c84
Metadata
Metadata
Assignees
Labels
A-cli-helpArea: built-in command-line helpArea: built-in command-line helpC-cleanupCategory: cleanup within the codebaseCategory: cleanup within the codebaseE-easyExperience: EasyExperience: EasyP-lowPriority: LowPriority: LowS-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewStatus: Issue or feature is accepted, and has a team member available to help mentor or review
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
WeiTheShinobi commentedon Jan 3, 2024
@rustbot claim
Auto merge of #13249 - WeiTheShinobi:update_dependency_handlebars, r=…
Auto merge of #13249 - WeiTheShinobi:update_dependency_handlebars, r=…
weihanglo commentedon Jan 4, 2024
Resolved by #13249.