-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Publishing multiple packages should not say “You may press ctrl-c to skip waiting” #15005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The first question is if the message is serving its purpose. If so, then it would be needed in these cases. What could instead work is to re-word it to tell users that the current package would be available shortly but that there are X packages that are unpublished. The message was added in #11230 (though started in #11062) and tweaked in #11713. Neither seems to talk about the motivation. #11062 initially didn't call out ctrl-c but I'm not seeing the discussion where it changed. I also checked meeting notes from that time and I'm not seeing it. |
#15632) ### What does this PR try to resolve? Telling people they are free to hit ctrl-c while waiting for packages could mean some packages may not be published and the user wouldn't know until they get a complaint about a missing package. Instead, if there are remaining packages, we'll tell the user that. Fixes #15005 ### How to test and review this PR?
Uh oh!
There was an error while loading. Please reload this page.
Problem
When using the new unstable support for publishing multiple packages in one command, Cargo prints its usual message during uploading:
However, this does not make sense for any packages but the last one, because the only things it could possibly do are cancel the remaining packages (unwanted), run the risk of erroring out due to not waiting before publishing the next package (unwanted), or do nothing (misleading).
Possible Solution(s)
Cargo should not print this message. Perhaps a more useful while-you-wait message would be to report how many packages remain to be published (or how many have been and the total).
Notes
@rustbot label +Z-package-workspace
Version
The text was updated successfully, but these errors were encountered: