-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Open
Labels
A-directory-sourceArea: directory sources (vendoring)Area: directory sources (vendoring)Command-packageS-needs-rfcStatus: Needs an RFC to make progress.Status: Needs an RFC to make progress.
Description
https://github.com/servo/mozjs is a snapshot of the JS engine from https://hg.mozilla.org/mozilla-central/, wrapped up in a crate that invokes the native Makefile build from build.rs
. This native build happens to invoke cargo build
on a Rust project that exists inside https://hg.mozilla.org/mozilla-central/ and generates a binary that is used in the JS engine build. The build works fine, but running cargo package
causes the subdirectory containing this project to be ignored (mozjs/js/src/frontend/binsource) because it contains a Cargo.toml. I am no longer able to publish new versions of mozjs on crates.io since this Rust library was introduced upstream because of this restriction.
Metadata
Metadata
Assignees
Labels
A-directory-sourceArea: directory sources (vendoring)Area: directory sources (vendoring)Command-packageS-needs-rfcStatus: Needs an RFC to make progress.Status: Needs an RFC to make progress.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
alexcrichton commentedon May 8, 2019
I believe this happens roughly around here, and unfortunately there's no clear fix for this I know of.
SimonSapin commentedon Sep 24, 2019
@alexcrichton What do you think of not excluding a subpackage from the tarball if that directory is explicitly listed in
include
?SimonSapin commentedon Sep 24, 2019
By no clear fix, did you mean in the design decision of what the behavior should be, or are there implementation difficulties?
alexcrichton commentedon Sep 25, 2019
I believe this is both a difficult design decision as well has something which has a number of implementation difficulties. I think that supporting this would require an RFC as well as a champion for the implementation.
cargo install fj-app
has been broken since version 0.24.0 hannobraun/fornjot#1356nicoburns commentedon Feb 7, 2025
This would be a "dumb workaround", but could the
Cargo.toml
be renamed to something else prior to packaging, and then renamed back in thebuild.rs
, in order to avoid Cargo's package detection?