Skip to content

Conversation

cbeuw
Copy link
Contributor

@cbeuw cbeuw commented May 19, 2022

Cargo requires a C compiler to build, this should be specified in README

$ cargo tree --invert cc
cc v1.0.73
[build-dependencies]
├── curl-sys v0.4.55+curl-7.83.1
│   ├── cargo v0.63.0 (C:\Users\IEUser\Documents\cargo)
│   └── curl v0.4.43
│       ├── cargo v0.63.0 (C:\Users\IEUser\Documents\cargo)
│       ├── crates-io v0.34.0 (C:\Users\IEUser\Documents\cargo\crates\crates-io)
│       │   └── cargo v0.63.0 (C:\Users\IEUser\Documents\cargo)
│       └── git2-curl v0.15.0
│           └── cargo v0.63.0 (C:\Users\IEUser\Documents\cargo)
├── libgit2-sys v0.13.4+1.4.2
│   ├── cargo v0.63.0 (C:\Users\IEUser\Documents\cargo)
│   └── git2 v0.14.4
│       ├── cargo v0.63.0 (C:\Users\IEUser\Documents\cargo)
│       ├── cargo-test-support v0.1.0 (C:\Users\IEUser\Documents\cargo\crates\cargo-test-support)
│       │   [dev-dependencies]
│       │   └── cargo v0.63.0 (C:\Users\IEUser\Documents\cargo)
│       └── git2-curl v0.15.0 (*)
├── libnghttp2-sys v0.1.7+1.45.0
│   └── curl-sys v0.4.55+curl-7.83.1 (*)
├── libssh2-sys v0.2.23
│   └── libgit2-sys v0.13.4+1.4.2 (*)
└── libz-sys v1.1.6
    ├── curl-sys v0.4.55+curl-7.83.1 (*)
    ├── flate2 v1.0.23
    │   ├── cargo v0.63.0 (C:\Users\IEUser\Documents\cargo)
    │   └── cargo-test-support v0.1.0 (C:\Users\IEUser\Documents\cargo\crates\cargo-test-support) (*)
    │   [build-dependencies]
    │   └── cargo v0.63.0 (C:\Users\IEUser\Documents\cargo)
    ├── libgit2-sys v0.13.4+1.4.2 (*)
    └── libssh2-sys v0.2.23 (*)

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2022
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for your contribution!

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 20, 2022

📌 Commit 3c1596d has been approved by weihanglo

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2022
@bors
Copy link
Contributor

bors commented May 20, 2022

⌛ Testing commit 3c1596d with merge f624095...

@bors
Copy link
Contributor

bors commented May 20, 2022

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing f624095 to master...

@bors bors merged commit f624095 into rust-lang:master May 20, 2022
@cbeuw cbeuw deleted the patch-1 branch May 20, 2022 09:10
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2022
Update cargo

10 commits in a4c1cd0eb6b18082a7e693f5a665548fe1534be4..39ad1039d9e3e1746177bf5d134af4c164f95528
2022-05-20 00:55:25 +0000 to 2022-05-25 00:50:02 +0000

* doc: discuss build script instruction order (rust-lang/cargo#10600)
* Require http-registry URLs to end with a '/' (rust-lang/cargo#10698)
* No printing executable names when running tests and benchmarks with json message format (rust-lang/cargo#10691)
* Restore proper error for crate not in local reg (rust-lang/cargo#10683)
* Update libcurl (rust-lang/cargo#10696)
* Fixed small typos (rust-lang/cargo#10693)
* fix bugs with `workspace` key and `update_toml` (rust-lang/cargo#10685)
* Bump to 0.64.0, update changelog (rust-lang/cargo#10687)
* List C compiler as a build dependency in README (rust-lang/cargo#10678)
* Add unstable `rustc-check-cfg` build script output (rust-lang/cargo#10539)

r? `@ehuss`
@ehuss ehuss added this to the 1.63.0 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants