Skip to content

Add missing edition #11265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

Add missing edition #11265

merged 1 commit into from
Oct 20, 2022

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Oct 20, 2022

When I read this doc, I found that we are missing the edition key in this manifest. I think we should add it because cargo new always does this.

@0xPoe
Add missing edition
96bf10e 
Signed-off-by: hi-rustin <[email protected]>
@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2022
@epage
Copy link
Contributor

epage commented Oct 20, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2022

📌 Commit 96bf10e has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2022
@bors
Copy link
Contributor

bors commented Oct 20, 2022

⌛ Testing commit 96bf10e with merge b1b25a0...

@weihanglo
Copy link
Member

Should we document the process of updating edition field throughout Cargo book?

cargo/src/cargo/core/features.rs

Lines 136 to 149 in a6e72d0

/// ## Stabilization instructions
///
/// - Set [`LATEST_UNSTABLE`] to None.
/// - Set [`LATEST_STABLE`] to the new version.
/// - Update [`is_stable`] to `true`.
/// - Set the editionNNNN feature to stable in the [`features!`] macro invocation below.
/// - Update any tests that are affected.
/// - Update the man page for the `--edition` flag.
/// - Update unstable.md to move the edition section to the bottom.
/// - Update the documentation:
/// - Update any features impacted by the edition.
/// - Update manifest.md#the-edition-field.
/// - Update the `--edition` flag (options-new.md).
/// - Rebuild man pages.

@bors
Copy link
Contributor

bors commented Oct 20, 2022

☀️ Test successful - checks-actions
Approved by: epage
Pushing b1b25a0 to master...

@bors bors merged commit b1b25a0 into rust-lang:master Oct 20, 2022
@weihanglo weihanglo mentioned this pull request Oct 22, 2022
Merged
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2022
@weihanglo
Update cargo
9926f6e 
5 commits in 3ff044334f0567ce1481c78603aeee7211b91623..071eeaf210708219a5a1b2c4728ca2f97df7f2ae
2022-10-17 20:25:00 +0000 to 2022-10-22 01:17:55 +0000

- fix: Remove leading newline in vendor output (rust-lang/cargo#11273)
- Fix publishing with a dependency on a sparse registry (rust-lang/cargo#11268)
- Add missing edition (rust-lang/cargo#11265)
- fix(publish): Check remote git registry more than once post-publish (rust-lang/cargo#11255)
- Fix typo (rust-lang/cargo#11258)
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2022
@bors
Auto merge of rust-lang#103400 - weihanglo:update-cargo, r=weihanglo
5a0f454 
Update cargo

5 commits in 3ff044334f0567ce1481c78603aeee7211b91623..071eeaf210708219a5a1b2c4728ca2f97df7f2ae 2022-10-17 20:25:00 +0000 to 2022-10-22 01:17:55 +0000

- fix: Remove leading newline in vendor output (rust-lang/cargo#11273)
- Fix publishing with a dependency on a sparse registry (rust-lang/cargo#11268)
- Add missing edition (rust-lang/cargo#11265)
- fix(publish): Check remote git registry more than once post-publish (rust-lang/cargo#11255)
- Fix typo (rust-lang/cargo#11258)

r? `@ghost`
@0xPoe
Copy link
Member Author

0xPoe commented Oct 23, 2022

Should we document the process of updating edition field throughout Cargo book?

cargo/src/cargo/core/features.rs

Lines 136 to 149 in a6e72d0

/// ## Stabilization instructions
///
/// - Set [`LATEST_UNSTABLE`] to None.
/// - Set [`LATEST_STABLE`] to the new version.
/// - Update [`is_stable`] to `true`.
/// - Set the editionNNNN feature to stable in the [`features!`] macro invocation below.
/// - Update any tests that are affected.
/// - Update the man page for the `--edition` flag.
/// - Update unstable.md to move the edition section to the bottom.
/// - Update the documentation:
/// - Update any features impacted by the edition.
/// - Update manifest.md#the-edition-field.
/// - Update the `--edition` flag (options-new.md).
/// - Rebuild man pages.

But I think we have the edition guidebook.

@0xPoe 0xPoe deleted the rustin-patch-missing branch October 23, 2022 07:28
@ehuss ehuss added this to the 1.66.0 milestone Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@0xPoe @rust-highfive @epage @bors @weihanglo @ehuss