Skip to content

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

Bump crate versions of cargo-util and crates-io.

  • cargo-util: The latest commit published to crates.io is 4bc8f24 (v0.2.2 on docs.rs).
    No major change and new features. Looks like we only need a patch version bump.
  • crates-io: The latest commit published to crates.io is d1fd9fe (v0.34.0 on docs.rs).
    We derive Deserialize for some structs. Not sure whether deriving a trait counts breaks things. Perhaps breaks someone using remote deriving? Anyway, I made it a breaking release for visibility.

This PR also updates root Cargo.toml accordingly.

How should we test and review this PR?

Find any potential breakage I overlooked, and suggest a different kind of version bump.

Additional information

I could do this right before the next release, but I'd rather do it now due to my poor memory.

@rustbot
Copy link
Collaborator

rustbot commented Nov 13, 2022

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2022
Copy link
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ❤️

@epage
Copy link
Contributor

epage commented Nov 14, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Nov 14, 2022

📌 Commit 7dc316e has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2022
@bors
Copy link
Contributor

bors commented Nov 14, 2022

⌛ Testing commit 7dc316e with merge 26f4c03...

@bors
Copy link
Contributor

bors commented Nov 14, 2022

☀️ Test successful - checks-actions
Approved by: epage
Pushing 26f4c03 to master...

@bors bors merged commit 26f4c03 into rust-lang:master Nov 14, 2022
weihanglo added a commit to weihanglo/rust that referenced this pull request Nov 16, 2022
5 commits in a3dfea71ca0c888a88111086898aa833c291d497..16b097879b6f117c8ae698aab054c87f26ff325e
2022-11-11 03:50:47 +0000 to 2022-11-14 23:28:16 +0000
- improve error message for cargo add/remove (rust-lang/cargo#11375)
- Bump crate versions of `cargo-util` and `crates-io` (rust-lang/cargo#11369)
- doc(changelog): suggestions of cargo fix are nightly only (rust-lang/cargo#11373)
- Add warning when PATH env separator is in project path (rust-lang/cargo#11318)
- Fix git2 safe-directory disable (rust-lang/cargo#11366)
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2022
Update cargo

5 commits in a3dfea71ca0c888a88111086898aa833c291d497..16b097879b6f117c8ae698aab054c87f26ff325e 2022-11-11 03:50:47 +0000 to 2022-11-14 23:28:16 +0000
- improve error message for cargo add/remove (rust-lang/cargo#11375)
- Bump crate versions of `cargo-util` and `crates-io` (rust-lang/cargo#11369)
- doc(changelog): suggestions of cargo fix are nightly only (rust-lang/cargo#11373)
- Add warning when PATH env separator is in project path (rust-lang/cargo#11318)
- Fix git2 safe-directory disable (rust-lang/cargo#11366)

r? `@ghost`
@weihanglo weihanglo deleted the bump-versions branch November 25, 2022 01:16
@ehuss ehuss added this to the 1.67.0 milestone Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants