Skip to content

chore: Upgrade to env_logger #11417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2022
Merged

chore: Upgrade to env_logger #11417

merged 1 commit into from
Nov 25, 2022
+1 −1

Conversation

epage
Copy link
Contributor

@epage epage commented Nov 24, 2022

This removes one path to atty.

Others:

This is part of #11416

@epage
chore: Upgrade to env_logger
5a3bf71 
This removes one path to `atty`.

Others:
- clap: fixed in 4.0.27
- pretty-env-logger: seanmonstar/pretty-env-logger#52 needs to be resolved first
- snapbox: this will be fixed soonish but is also only a test dependency
- direct dependency

This is part of rust-lang#11416
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2022

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2022
@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 24, 2022

📌 Commit ead6e24 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2022
@bors
Copy link
Contributor

bors commented Nov 24, 2022

⌛ Testing commit ead6e24 with merge ef93600...

bors added a commit that referenced this pull request Nov 24, 2022
@bors
Auto merge of #11417 - epage:logger, r=weihanglo
ef93600 
chore: Upgrade to env_logger

This removes one path to `atty`.

Others:
- clap: fixed in 4.0.27
- pretty-env-logger: seanmonstar/pretty-env-logger#52 needs to be resolved first
- snapbox: this will be fixed soonish but is also only a test dependency
- direct dependency

This is part of #11416
@bors
Copy link
Contributor

bors commented Nov 24, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2022
@epage
Copy link
Contributor Author

epage commented Nov 25, 2022

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2022
epage added a commit to epage/cargo that referenced this pull request Nov 25, 2022
@epage
fix: Move off atty to resolve soundness issue
dd31a47 
There is a soundness issue with atty when building on Windows with a
custom allocator.

This PR switches direct dependencies on atty to is-terminal.  New semver
compatible versions of clap and snapbox remove atty. rust-lang#11417 upgrades
env_logger to remove it from there.

Fixes rust-lang#11415
@epage epage mentioned this pull request Nov 25, 2022
Merged
epage added a commit to epage/cargo that referenced this pull request Nov 25, 2022
@epage
fix: Move off atty to resolve soundness issue
1f9ca5b 
There is a soundness issue with atty when building on Windows with a
custom allocator.

This PR switches direct dependencies on atty to is-terminal.  New semver
compatible versions of clap and snapbox remove atty. rust-lang#11417 upgrades
env_logger to remove it from there.

Fixes rust-lang#11415
@weihanglo
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2022
@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2022

📌 Commit 5a3bf71 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Nov 25, 2022
@bors
Copy link
Contributor

bors commented Nov 25, 2022

⌛ Testing commit 5a3bf71 with merge ee755e7...

@bors
Copy link
Contributor

bors commented Nov 25, 2022

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing ee755e7 to master...

@bors bors merged commit ee755e7 into rust-lang:master Nov 25, 2022
@bors bors mentioned this pull request Nov 25, 2022
Merged
@epage epage deleted the logger branch November 25, 2022 12:27
epage added a commit to epage/cargo that referenced this pull request Nov 25, 2022
@epage
fix: Move off atty to resolve soundness issue
48895b1 
There is a soundness issue with atty when building on Windows with a
custom allocator.

This PR switches direct dependencies on atty to is-terminal.  New semver
compatible versions of clap and snapbox remove atty. rust-lang#11417 upgrades
env_logger to remove it from there.

Fixes rust-lang#11415
bors added a commit that referenced this pull request Nov 25, 2022
@bors
Auto merge of #11420 - epage:atty, r=weihanglo
e027c4b 
fix: Move off atty to resolve soundness issue

There is a soundness issue with atty when building on Windows with a custom allocator.

This PR switches direct dependencies on atty to is-terminal.  New semver compatible versions of clap and snapbox remove atty. #11417 upgrades env_logger to remove it from there.

Fixes #11416
weihanglo added a commit to weihanglo/rust that referenced this pull request Nov 25, 2022
@weihanglo
Update cargo

Verified

This commit was signed with the committer’s verified signature. The key has expired.
weihanglo Weihang Lo
GPG key ID: D7DBF189825E82E7
Expired
Verified
Learn about vigilant mode
083d6eb 
5 commits in ba607b23db8398723d659249d9abf5536bc322e5..e027c4b5d25af2119b1956fac42863b9b3242744
2022-11-22 20:52:39 +0000 to 2022-11-25 19:44:46 +0000
- fix: Move off atty to resolve soundness issue (rust-lang/cargo#11420)
- add newline char to `cargo install .` error message for easier reading. (rust-lang/cargo#11401)
- chore: Upgrade to env_logger (rust-lang/cargo#11417)
- Change rustdoc-scrape-examples to be a target-level configuration (rust-lang/cargo#10343)
- temporarily disable test `lto::test_profile` (rust-lang/cargo#11419)
@weihanglo weihanglo mentioned this pull request Nov 25, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 26, 2022
@matthiaskrgr
Rollup merge of rust-lang#104915 - weihanglo:update-cargo, r=weihanglo

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
854ef22 
Update cargo

5 commits in ba607b23db8398723d659249d9abf5536bc322e5..e027c4b5d25af2119b1956fac42863b9b3242744 2022-11-22 20:52:39 +0000 to 2022-11-25 19:44:46 +0000

- fix: Move off atty to resolve soundness issue (rust-lang/cargo#11420)
- add newline char to `cargo install .` error message for easier reading. (rust-lang/cargo#11401)
- chore: Upgrade to env_logger (rust-lang/cargo#11417)
- Change rustdoc-scrape-examples to be a target-level configuration (rust-lang/cargo#10343)
- temporarily disable test `lto::test_profile` (rust-lang/cargo#11419)

r+ `@ghost`
weihanglo added a commit to weihanglo/rust that referenced this pull request Nov 27, 2022
@weihanglo
Update cargo

Verified

This commit was signed with the committer’s verified signature. The key has expired.
weihanglo Weihang Lo
GPG key ID: D7DBF189825E82E7
Expired
Verified
Learn about vigilant mode
1e5dad0 
5 commits in ba607b23db8398723d659249d9abf5536bc322e5..e027c4b5d25af2119b1956fac42863b9b3242744
2022-11-22 20:52:39 +0000 to 2022-11-25 19:44:46 +0000
- fix: Move off atty to resolve soundness issue (rust-lang/cargo#11420)
- add newline char to `cargo install .` error message for easier reading. (rust-lang/cargo#11401)
- chore: Upgrade to env_logger (rust-lang/cargo#11417)
- Change rustdoc-scrape-examples to be a target-level configuration (rust-lang/cargo#10343)
- temporarily disable test `lto::test_profile` (rust-lang/cargo#11419)
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2022
@bors
Auto merge of rust-lang#104915 - weihanglo:update-cargo, r=ehuss
dd12cd6 
Update cargo

5 commits in ba607b23db8398723d659249d9abf5536bc322e5..e027c4b5d25af2119b1956fac42863b9b3242744 2022-11-22 20:52:39 +0000 to 2022-11-25 19:44:46 +0000

- fix: Move off atty to resolve soundness issue (rust-lang/cargo#11420)
- add newline char to `cargo install .` error message for easier reading. (rust-lang/cargo#11401)
- chore: Upgrade to env_logger (rust-lang/cargo#11417)
- Change rustdoc-scrape-examples to be a target-level configuration (rust-lang/cargo#10343)
- temporarily disable test `lto::test_profile` (rust-lang/cargo#11419)

r+ `@ghost`
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Dec 3, 2022
@bors
Auto merge of #104915 - weihanglo:update-cargo, r=ehuss
36ab1bd 
Update cargo

5 commits in ba607b23db8398723d659249d9abf5536bc322e5..e027c4b5d25af2119b1956fac42863b9b3242744 2022-11-22 20:52:39 +0000 to 2022-11-25 19:44:46 +0000

- fix: Move off atty to resolve soundness issue (rust-lang/cargo#11420)
- add newline char to `cargo install .` error message for easier reading. (rust-lang/cargo#11401)
- chore: Upgrade to env_logger (rust-lang/cargo#11417)
- Change rustdoc-scrape-examples to be a target-level configuration (rust-lang/cargo#10343)
- temporarily disable test `lto::test_profile` (rust-lang/cargo#11419)

r+ `@ghost`
@ehuss ehuss added this to the 1.67.0 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@epage @rustbot @weihanglo @bors @ehuss