[beta-1.76.0] fix(--package): accept ? if it's a valid pkgid spec
#13318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(`--package`): accept `?` if it's a valid pkgid spec
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
|
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 18, 2024
[beta-1.76.0] fix(`--package`): accept `?` if it's a valid pkgid spec Beta backports: - <#13315> In order to make CI pass, the following PRs are also cherry-picked: -
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
I think you'll also need to backport #13220. |
|
Thanks @ehuss. Cherry-picked :) |
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 21, 2024
…nglo [beta-1.76.0] backport cargo 1 commits in ddec30889aff0c38118bcbeb59597d0bd85eddcd..c84b367471a2db61d2c2c6aab605b14130b8a31b 2024-01-02 23:23:28 +0000 to 2024-01-18 16:17:02 +0000 - [beta-1.76.0] fix(`--package`): accept `?` if it's a valid pkgid spec (rust-lang/cargo#13318) r? ghost
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 22, 2024
…nglo [beta-1.76.0] backport cargo 1 commits in ddec30889aff0c38118bcbeb59597d0bd85eddcd..c84b367471a2db61d2c2c6aab605b14130b8a31b 2024-01-02 23:23:28 +0000 to 2024-01-18 16:17:02 +0000 - [beta-1.76.0] fix(`--package`): accept `?` if it's a valid pkgid spec (rust-lang/cargo#13318) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta backports:
--package): accept?if it's a valid pkgid spec #13315In order to make CI pass, the following PRs are also cherry-picked: