Skip to content

Conversation

ifropc
Copy link
Contributor

@ifropc ifropc commented Aug 17, 2024

Addressing comments by Weihang and Ed from #14326

@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2024
@ifropc
Copy link
Contributor Author

ifropc commented Aug 17, 2024

r? @weihanglo

@rustbot rustbot assigned weihanglo and unassigned ehuss Aug 17, 2024
- Remove "execs" method
@ifropc ifropc force-pushed the lockfile-path-tests branch from 97fb258 to a1d9528 Compare August 17, 2024 19:51
@ifropc ifropc force-pushed the lockfile-path-tests branch from a1d9528 to aa7ead5 Compare August 17, 2024 19:52
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. Thank you!

@bors r+

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 18, 2024

📌 Commit aa7ead5 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2024
@bors
Copy link
Contributor

bors commented Aug 18, 2024

⌛ Testing commit aa7ead5 with merge 4494032...

@bors
Copy link
Contributor

bors commented Aug 18, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 4494032 to master...

@bors bors merged commit 4494032 into rust-lang:master Aug 18, 2024
22 checks passed
@weihanglo weihanglo linked an issue Aug 18, 2024 that may be closed by this pull request
@weihanglo
Copy link
Member

I forgot. We also need an unstable doc. Something like https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#precise-pre-release. See the new tracking issue #14421

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 22, 2024
Update cargo

12 commits in ba8b39413c74d08494f94a7542fe79aa636e1661..8f40fc59fb0c8df91c97405785197f3c630304ea
2024-08-16 22:48:57 +0000 to 2024-08-21 22:37:06 +0000
- Tests rely on absence of RUST_BACKTRACE (rust-lang/cargo#14441)
- fix: -Cmetadata includes whether extra rustflags is same as host (rust-lang/cargo#14432)
- [mdman] Normalize newlines when rendering options (rust-lang/cargo#14428)
- fix: doctest respects Cargo's color options (rust-lang/cargo#14425)
- Be more permissive while packaging unpublishable crates. (rust-lang/cargo#14408)
- fix: Limiting pre-release match semantics to use only on `OptVersionReq::Req` (rust-lang/cargo#14412)
- test: add a regression test for Issue 14409 (rust-lang/cargo#14430)
- chore: update label trigger for Command-info (rust-lang/cargo#14422)
- doc: add lockfile-path unstable doc section (rust-lang/cargo#14423)
- doc: update lockfile-path tracking issue (rust-lang/cargo#14424)
- fix: remove list owners feature of info subcommand (rust-lang/cargo#14418)
- Lockfile path tests (follow-up) (rust-lang/cargo#14417)
@rustbot rustbot added this to the 1.82.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: add option to specify path to Cargo.lock
5 participants