docs: Remove statement that dep features are optional #15408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
rustbot
added
A-documenting-cargo-itself
weihanglo
reviewed
Apr 8, 2025
| // https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html. | ||
| "req": "^0.6", | ||
| // Array of features (as strings) enabled for this dependency. | ||
| // May be omitted since Cargo 1.84. |
There was a problem hiding this comment.
Could you = give a concrete example of the failing case, and the step to produce?
|
@rustbot author |
rustbot
removed
the
S-waiting-on-review
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
epage
added a commit
to epage/cargo
that referenced
this pull request
Sep 12, 2025
The current wording (from rust-lang#14839) makes it sound like new Cargo doesn't care about the `features` entries when in reality Cargo does care still, the field is just defaulted. Closes rust-lang#15408
epage
added a commit
to epage/cargo
that referenced
this pull request
Sep 12, 2025
The current wording (from rust-lang#14839) makes it sound like new Cargo doesn't care about the `features` entries when in reality Cargo does care still, the field is just defaulted. Closes rust-lang#15408
epage
added a commit
to epage/cargo
that referenced
this pull request
Sep 12, 2025
The current wording (from rust-lang#14839) makes it sound like new Cargo doesn't care about the `features` entries when in reality Cargo does care still, the field is just defaulted. Closes rust-lang#15408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created my own registry by using a git repo and found that leaving the
featuresin the dependencies in an index entry does not work. When a crate A has dependencies with features and you try to use it via the registry in crate B the build fails when A uses symbols only available by said features.I tested with with 1.86