fix: remove unnecessary workaround in standard_lib test #15522
Conversation
rustbot
added
the
S-waiting-on-review
|
Oops, fixing tests... |
motorailgun
force-pushed
the
unnecessary-workaround
branch
3 times, most recently
from
0ecfd35 to
c24644f
Compare
|
I must admit that I'm kind of stuck here. The original issue, where ld needed to be present inside sysroot on @weihanglo Would you mind looking into the failing test if possible...? |
tests/testsuite/standard_lib.rs
Outdated
| // more information. | ||
| // args.push("--sysroot".to_string()); | ||
| // args.push("/path/to/nowhere".to_string()); | ||
| args.push("--sysroot".to_string()); |
There was a problem hiding this comment.
Because the hack predates the test build_std_with_no_arg_for_core_only_target, which really requires a target shared library from sysroot, for example ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/aarch64-unknown-none/lib/
There was a problem hiding this comment.
One way to fix this is also ensure that the --target passed in is rustc host target.
There was a problem hiding this comment.
Oh I see. Well, ensuring that passed --target is the host target seems a good way to go.
There was a problem hiding this comment.
(By the way, thank you for your advice)
motorailgun
force-pushed
the
unnecessary-workaround
branch
from
c24644f to
72eec5e
Compare
motorailgun
force-pushed
the
unnecessary-workaround
branch
from
72eec5e to
ff1849f
Compare
Update cargo 9 commits in 47c911e9e6f6461f90ce19142031fe16876a3b95..68db37499f2de8acef704c73d9031be6fbcbaee4 2025-05-14 17:53:17 +0000 to 2025-05-22 14:27:15 +0000 - chore(gh): Add new-lint issue template (rust-lang/cargo#15575) - fix(toml): Remove workaround for rustc frontmatter support (rust-lang/cargo#15570) - fix(vendor)!: vendor files with .rej/.orig suffix (rust-lang/cargo#15569) - fix(vendor)!: direct extraction for registry sources (rust-lang/cargo#15514) - chore(deps): update msrv (1 version) to v1.87 (rust-lang/cargo#15530) - Fix comment for cargo/core/compiler/fingerprint/mod.rs (rust-lang/cargo#15565) - fix: remove unnecessary workaround in standard_lib test (rust-lang/cargo#15522) - Allow configuring arbitrary codegen backends (rust-lang/cargo#15562) - Update dependencies (rust-lang/cargo#15557) r? ghost
Update cargo 9 commits in 47c911e9e6f6461f90ce19142031fe16876a3b95..68db37499f2de8acef704c73d9031be6fbcbaee4 2025-05-14 17:53:17 +0000 to 2025-05-22 14:27:15 +0000 - chore(gh): Add new-lint issue template (rust-lang/cargo#15575) - fix(toml): Remove workaround for rustc frontmatter support (rust-lang/cargo#15570) - fix(vendor)!: vendor files with .rej/.orig suffix (rust-lang/cargo#15569) - fix(vendor)!: direct extraction for registry sources (rust-lang/cargo#15514) - chore(deps): update msrv (1 version) to v1.87 (rust-lang/cargo#15530) - Fix comment for cargo/core/compiler/fingerprint/mod.rs (rust-lang/cargo#15565) - fix: remove unnecessary workaround in standard_lib test (rust-lang/cargo#15522) - Allow configuring arbitrary codegen backends (rust-lang/cargo#15562) - Update dependencies (rust-lang/cargo#15557) r? ghost
What does this PR try to resolve?
As issue rustc can't find the linker when
--sysrootis set to a local build of the sysroot rust#125246 has already been fixed, there must be no need for commenting out--sysrootanymore in the tests.The bug mentioned in
shared_std_dependency_rebuild()looks to be already solved and does not reproduce. So I guess it's safe to un-comment those lines.