Make lldb_works_after_trimmed test robust against lldb output
#15686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions of lldb (including the version in CI) print "Process $PID resuming" after `continue`, breaking the test. Add another wildcard to allow for that, without breaking the test on versions of lldb that *don't* print that message.
rustbot
added
the
S-waiting-on-review
weihanglo
reviewed
Jun 20, 2025
|
@weihanglo Looking at the test failure on macOS, I think more is wrong with this test than this PR would fix, so yeah, I think disabling it is the right answer. I'll send a PR doing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of lldb (including the version in CI) print "Process $PID
resuming" after
continue, breaking the test. Add another wildcard toallow for that, without breaking the test on versions of lldb that
don't print that message.
What does this PR try to resolve?
Fixes a CI test failure.
How to test and review this PR?
This PR aims to resolve a CI test failure, so it should pass CI.