Graph resolve #157
Merged
Graph resolve #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a package had both bin and lib deps, `cargo test` was not building the `lib` dependency when building the bins with `--test`. This commit adds an extra "test" profile (not compiled with --test) for situations such as this which is filtered out normally but kept around for the `cargo test` case.
This touches up the filtering logic to ensure that upstream dependencies as well as local dependencies are built with optimizations when `cargo build --release` is used.
This commit adds support for passing --extern to dependencies. It allows multiple copies of the same named dependency in the system, as long as they come from different repos.
| impl<S: hash::Writer> Hash<S> for PackageId { | ||
| fn hash(&self, state: &mut S) { | ||
| self.name.hash(state); | ||
| self.version.to_str().hash(state); |
There was a problem hiding this comment.
FWIW, proper hashing of semver::Version is in the queue: rust-lang/rust#15564.
Most notably, `resolve` now takes the root, so it can properly link the root package with its dependencies (which is required to build the --externs for the root package).
Conflicts: src/cargo/core/resolver.rs src/cargo/ops/cargo_rustc.rs
This was referenced Jul 10, 2014
This fixes `cargo test` to only test the *local* package
bors
added a commit
that referenced
this pull request
Jul 10, 2014
This incorporates previous bugfixes by @alexcrichton that are still stuck in bors.
bors
added a commit
to alexcrichton/cargo
that referenced
this pull request
Sep 2, 2014
…ichton This incorporates previous bugfixes by @alexcrichton that are still stuck in bors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates previous bugfixes by @alexcrichton that are still stuck in bors.