Skip to content

Slightly improve error messages #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

matklad
Copy link
Member

@matklad matklad commented May 8, 2016

  • print "build failed" error to stderr (have not executed that line, but it should work :) )
  • don't print "warning: warning:". Now the error looks like this:
warning: could not determine a browser to open docs with, tried:
        xdg-open
        gnome-open
        kde-open

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@matklad
Copy link
Member Author

matklad commented May 8, 2016

Not sure why CI fails on Mac/beta. Looks like an unrelated race condition

@matklad matklad mentioned this pull request May 8, 2016
@alexcrichton
Copy link
Member

@bors: r+ 207d088e5b2a6ceb38d2237dc33b0a700be16f95

@bors
Copy link
Contributor

bors commented May 9, 2016

⌛ Testing commit 207d088 with merge 667a8ab...

@bors
Copy link
Contributor

bors commented May 9, 2016

💔 Test failed - cargo-win-msvc-64

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented May 16, 2016

📌 Commit 49b6d04 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented May 16, 2016

⌛ Testing commit 49b6d04 with merge 52e9fbb...

@bors
Copy link
Contributor

bors commented May 16, 2016

💔 Test failed - cargo-linux-64

@alexcrichton
Copy link
Member

@bors: retry

On Mon, May 16, 2016 at 11:13 AM, bors [email protected] wrote:

[image: 💔] Test failed - cargo-linux-64
http://buildbot.rust-lang.org/builders/cargo-linux-64/builds/1610


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2665 (comment)

@bors
Copy link
Contributor

bors commented May 16, 2016

⚡ Previous build results for cargo-cross-linux, cargo-win-gnu-32, cargo-win-gnu-64 are reusable. Rebuilding only cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-msvc-32, cargo-win-msvc-64...

@bors
Copy link
Contributor

bors commented May 16, 2016

💔 Test failed - cargo-win-msvc-64

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented May 18, 2016

⌛ Testing commit 49b6d04 with merge ed20d7b...

@bors
Copy link
Contributor

bors commented May 18, 2016

💔 Test failed - cargo-win-msvc-64

@alexcrichton
Copy link
Member

The other CI builds succeeded but this seems like a legitimate error happening 3 times in a row...

@matklad
Copy link
Member Author

matklad commented May 18, 2016

It is indeed genuie: cross_compile tests always fail locally, so I don't run them. I've tried to fix the test in question.

How should I run cross test locally? At the moment, I just cargo test with CFG_DISABLE_CROSS_TESTS=1.

@alexcrichton
Copy link
Member

You'll just need to install the cross-std, so if you're on rustup you can just do something like rustup target add i686-unknown-linux-gnu

@bors
Copy link
Contributor

bors commented May 20, 2016

☔ The latest upstream changes (presumably #2722) made this pull request unmergeable. Please resolve the merge conflicts.

* print "build failed" error to stderr
* don't print "warning: warning:"
@matklad matklad closed this Jun 9, 2016
@matklad matklad deleted the improve-errors branch June 9, 2016 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants