Skip to content

Conversation

rochamatcomp
Copy link
Contributor

Reorganize integration tests as one crate with many modules. Issue #4867. Rebased.
Tests into a testsuite directory, called as module from lib.rs. All of the extern crates moved to lib.rs. Direct use of the crates functionalities referenced by: use crates name.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@matklad
Copy link
Contributor

matklad commented Feb 13, 2018

Hm, this still does not seem to merge cleanly?

Could you try rebasing it again? It's ok to do git push --force-with-lease to the PR branch, so as not to create a separate PR.

If you need any help with rebasing, just ask! If you don't feel like doing it, I can handle it myself :)

bors added a commit that referenced this pull request Feb 21, 2018
Reorganize integration tests as one crate with many modules. Issue #4867. Rebased V3

This is an automatic rebase of @rochamatcomp's work in #5022, as requested in [#5038](#5038 (comment)).

I take no credit for the changes; I just wanted faster test for my work. :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants