-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add --travis flag and fix build on nightly rust #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you add a test for the |
I think so (didn't expect that such simple thing actually need a test). |
How come this updated |
rust-encoding should be updated because it had the same build problem. |
Could you run |
Umm... I'm not much familiar with git history rewriting magic. |
No worries! You'll probably want to do something like:
|
This reverts commit 4ee5fd3.
Conflicts: src/bin/new.rs src/cargo/ops/cargo_new.rs
I couldn't handle all the git-rebase power, so I fixed everything dirty mercurial way. I hope, this is fine too. |
And for future info @suhr, this breakage with rust master was introduced in rust-lang/rust#16917 where |
This implements #489 and fast-fixes #504.
PS: why &* thing is now explicit? This change is rather surprising for me.