Simplify RegistryPackage deserialization #5374
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
One downside of this approach (which the previous was trying to optimize for) is the double allocation of the I forget though the impact this had, but maybe worth some benchmarking on a larger project to see the impact? |
|
I haven't run any fancy statistical tests, but to the naked eye perf looks essentially the same. I've tried measuring fresh builds of Cargo and Servo. |
|
Ok! That should be fine then and perhaps I was too aggressive when optimizing historically! @bors: r+ |
|
📌 Commit 41e3861 has been approved by |
Simplify RegistryPackage deserialization Just mapping dependencies seems so much simpler than thread locals / deserializers with default. Am I missing something, or this indeed will work? :-) cc @Mark-Simulacrum
|
☀️ Test successful - status-appveyor, status-travis |
Just mapping dependencies seems so much simpler than thread locals / deserializers with default. Am I missing something, or this indeed will work? :-)
cc @Mark-Simulacrum