Skip to content

Provide error for testing non-workspaces packages with dev-dependencies. #6192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 20, 2018

Considering in most cases it just won't work, might as well display a better error message explaining why.

Closes #6183
Closes #5156

Considering in most cases it just won't work, might as well display
a better error message explaining why.
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 20, 2018

📌 Commit 786848a has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 20, 2018

⌛ Testing commit 786848a with merge 4d45a90...

bors added a commit that referenced this pull request Oct 20, 2018
Provide error for testing non-workspaces packages with dev-dependencies.

Considering in most cases it just won't work, might as well display a better error message explaining why.

Closes #6183, #5156
@bors
Copy link
Contributor

bors commented Oct 20, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 4d45a90 to master...

@bors bors merged commit 786848a into rust-lang:master Oct 20, 2018
@ehuss ehuss added this to the 1.31.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants