Parse escaped spaces in makefile dependencies #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that if a project has a file with a space in the name it will properly have its freshness calculated as opposed to always having it as a candidate to be rebuilt. Closes rust-lang#648
| Some(s) => s.to_string(), | ||
| None => break, | ||
| }; | ||
| while file.as_slice().ends_with("\\") { |
There was a problem hiding this comment.
What about foo\\ bar? (I.e. theoretically that's two deps foo\ and bar.)
There was a problem hiding this comment.
Currently it looks like a backslash doesn't need escaping in makefiles:
$ touch foo\\.c
$ gcc foo\\.c -MMD
$ cat foo\\.d
foo\.o: foo\.c
I do think that this conversion is a little lossy, but I also think that it correctly parses any rustc-generated dependency file.
bors
added a commit
that referenced
this pull request
Oct 6, 2014
This means that if a project has a file with a space in the name it will properly have its freshness calculated as opposed to always having it as a candidate to be rebuilt. Closes #648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that if a project has a file with a space in the name it will
properly have its freshness calculated as opposed to always having it as a
candidate to be rebuilt.
Closes #648