Work with canonical URLs in [patch]
#7368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue with how the resolver processes
[patch]
annotations in manifests and lock files. Previously the resolver would
use the raw
Url
coming out of a manifest, but the rest of resolution,when comparing
SourceId
, uses a canonical form of aUrl
rather thanthe actual raw
Url
. This ended up causing discrepancies like thosefound in #7282.
To fix the issue all
patch
intermediate storage in the resolver uses anewly-added
CanonicalUrl
type instead of aUrl
. ThisCanonicalUrl
is then also used throughout the codebase, and alllookups in the resolver as switched to using
CanonicalUrl
instead ofUrl
, which...Closes #7282