[beta] Go back to not hashing RUSTFLAGS in -Cmetadata
#7459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a moral revert of rust-lang#6503 but not a literal code revert. This switches Cargo's behavior to avoid hashing compiler flags into `-Cmetadata` since we've now had multiple requests of excluding flags from the `-Cmetadata` hash: usage of `--remap-path-prefix` and PGO options. These options should only affect how the compiler is invoked/compiled and not radical changes such as symbol names, but symbol names are changed based on `-Cmetadata`. Instead Cargo will still track these flags internally, but only for reinvoking rustc, and not for caching separately based on rustc flags. Closes rust-lang#7416
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit be712ff has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit be712ff with merge 2f60d2389f88480aa58618f5db463a755bc49cdd... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors: r=ehuss |
|
📌 Commit e2637c0 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 30, 2019
[beta] Go back to not hashing `RUSTFLAGS` in `-Cmetadata` This is a beta backport of #7417
|
☀️ Test successful - checks-azure |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 1, 2019
1 commits in 4b105b6abfb12d6985ffe66670e8b2a85982291a..1c6ec66d5bae40e9dfd2fb82f091b5172c212d73 2019-09-25 17:26:54 +0000 to 2019-09-30 21:43:14 +0000 - [beta] Go back to not hashing `RUSTFLAGS` in `-Cmetadata` (rust-lang/cargo#7459)
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 2, 2019
…huss [BETA] Update cargo 1 commits in 4b105b6abfb12d6985ffe66670e8b2a85982291a..1c6ec66d5bae40e9dfd2fb82f091b5172c212d73 2019-09-25 17:26:54 +0000 to 2019-09-30 21:43:14 +0000 - [beta] Go back to not hashing `RUSTFLAGS` in `-Cmetadata` (rust-lang/cargo#7459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a beta backport of #7417