Fix overzealous clean -p for reserved names.
#8398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 6263d72 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2020
Update cargo 9 commits in 089cbb80b73ba242efdcf5430e89f63fa3b5328d..c26576f9adddd254b3dd63aecba176434290a9f6 2020-06-15 14:38:34 +0000 to 2020-06-23 16:21:21 +0000 - Adding environment variable CARGO_PKG_LICENSE_FILE (rust-lang/cargo#8387) - Enable "--target-dir" in "cargo install" (rust-lang/cargo#8391) - Add support for `workspace.metadata` table (rust-lang/cargo#8323) - Fix overzealous `clean -p` for reserved names. (rust-lang/cargo#8398) - Fix order-dependent feature resolution. (rust-lang/cargo#8395) - Correct mispelling of `cargo`. (rust-lang/cargo#8389) - Add missing license field. (rust-lang/cargo#8386) - Adding environment variable CARGO_PKG_LICENSE (rust-lang/cargo#8325) - Cut down on data fetch from git dependencies (rust-lang/cargo#8363)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8210 changed the way
clean -pworked, but in some ways it is a little too sloppy. If a package has a test namedbuild, then it would delete thebuilddirectory thinking an executable named "build" exists. This changes it so that it does not attempt to delete tests/benches from the uplift directory.