Basic URL canonicalization. Fixes #84 #88
Conversation
rust-lang#84. No tests because there's no preexisting network tests.
|
This may not actually fix #84. There is another |
|
Think I'll throw in a few unit tests at least. |
|
I've also stripped trailing |
brson
changed the title
| fn test_canonicalize_idents_by_stripping_dot_git() { | ||
| let ident = ident(&Remote(url("https://github.com/PistonDevelopers/piston.git"))); | ||
| assert_eq!(ident.as_slice(), "piston-1ad60373965e5b42"); | ||
| } |
There was a problem hiding this comment.
Just in case we change the hashing algorithm in the future, could this test just test equality of all the urls when hashed? (don't actually look at the specific hash).
Could you also add a test for case insensitivity? The one above just calculates one hash but it's not clear from the test that the hash was generated from a lowercase url.
There was a problem hiding this comment.
I will, but this is following the existing pattern.
|
r=me with a minor comment |
Basic URL canonicalization. Fixes #84
Basic URL canonicalization. Fixes rust-lang#84
The rustfix tool detects it, so let's inform the user what just happened! Closes rust-lang#88
...#84.
No tests because there's no preexisting network tests.